content/browser/notifications/type_converters.cc - Issue 2261283002: Add Notification images (Blink + desktop implementation)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/notifications/type_converters.cc

Issue 2261283002: Add Notification images (Blink + desktop implementation) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/notifications/notification_message_filter.cc ('K') | « content/browser/notifications/notification_message_filter.cc ('k') | content/browser/notifications/type_converters_unittest.cc » ('j') | third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/notifications/type_converters.cc

diff --git a/content/browser/notifications/type_converters.cc b/content/browser/notifications/type_converters.cc

index 823eaa16d6fa09fe584bead2a2f1a95c9920448d..7f44b65c2d3d303ed90331138513ba3d6e7e5f0c 100644

--- a/content/browser/notifications/type_converters.cc

+++ b/content/browser/notifications/type_converters.cc

@@ -36,6 +36,7 @@ TypeConverter<PlatformNotificationData, blink::mojom::NotificationPtr>::Convert(

notification_data.lang = notification->lang;

notification_data.body = base::UTF8ToUTF16(notification->body.get());

notification_data.tag = notification->tag;

+ notification_data.image = GURL(notification->image.get());

notification_data.icon = GURL(notification->icon.get());

notification_data.badge = GURL(notification->badge.get());

@@ -98,6 +99,7 @@ TypeConverter<blink::mojom::NotificationPtr, PlatformNotificationData>::Convert(

notification->lang = notification_data.lang;

notification->body = base::UTF16ToUTF8(notification_data.body);

notification->tag = notification_data.tag;

+ notification->image = notification_data.image.spec();

notification->icon = notification_data.icon.spec();

notification->badge = notification_data.badge.spec();