content/browser/notifications/notification_message_filter.cc - Issue 2261283002: Add Notification images (Blink + desktop implementation)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/notifications/notification_message_filter.cc

Issue 2261283002: Add Notification images (Blink + desktop implementation) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/notifications/platform_notification_service_impl.cc ('K') | « content/browser/notifications/notification_database_data_unittest.cc ('k') | content/browser/notifications/type_converters.cc » ('j') | third_party/WebKit/Source/modules/notifications/NotificationDataTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/notifications/notification_message_filter.cc

diff --git a/content/browser/notifications/notification_message_filter.cc b/content/browser/notifications/notification_message_filter.cc

index e37d21b6fe1b61a6bc02acdb37b422dd95ca1181..1565c14e168ef0a39b3fe503438ff67ec2422058 100644

--- a/content/browser/notifications/notification_message_filter.cc

+++ b/content/browser/notifications/notification_message_filter.cc

@@ -48,6 +48,10 @@ PlatformNotificationData SanitizeNotificationData(

// Returns true when |resources| looks ok, false otherwise.

bool ValidateNotificationResources(const NotificationResources& resources) {

Peter Beverloo 2016/08/22 20:11:07 We should probably check that the command line fla

johnme 2016/08/23 14:59:49 Done.

+ if (resources.image.width() > blink::kWebNotificationMaxImageWidthPx ||

+ resources.image.height() > blink::kWebNotificationMaxImageHeightPx) {

+ return false;

+ }

if (resources.notification_icon.width() >

blink::kWebNotificationMaxIconSizePx ||

resources.notification_icon.height() >