Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 226073003: Fix StrictTypeChecking on interface type attributes (Closed)

Created:
6 years, 8 months ago by fs
Modified:
6 years, 8 months ago
CC:
blink-reviews, kouhei+bindings_chromium.org, eric.carlson_apple.com, adamk+blink_chromium.org, aandrey+blink_chromium.org, Nils Barth (inactive), Nate Chapin, arv+blink, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, Rik, nessy, sof, feature-media-reviews_chromium.org, haraken, kojih, vcarbune.chromium, philipj_slow, jsbell+bindings_chromium.org, gasubic, Inactive, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Fix StrictTypeChecking on interface type attributes 'undefined'/'null' would be allowed even though they shouldn't (unless the attribute is marked as nullable.) Also attempts to simplify the signature required for implementing the nullable version of a interface type attribute. Adjust CanvasRenderingContext2D.currentTransform, HTMLMediaElement.controller and AudioBufferSourceNode.buffer slightly. BUG=249598 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171043

Patch Set 1 #

Patch Set 2 : Adjust AudioBuffersourceNode.buffer. #

Total comments: 4

Patch Set 3 : Mark HTMLMediaElement.error nullable. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -30 lines) Patch
M LayoutTests/canvas/currentTransform-null-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/webaudio/audiobuffersource-channels.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/webaudio/audiobuffersource-channels-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/scripts/v8_attributes.py View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/attributes.cpp View 3 chunks +6 lines, -2 lines 0 comments Download
M Source/bindings/tests/idls/TestObject.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.cpp View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 1 2 3 chunks +42 lines, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.idl View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 1 chunk +1 line, -8 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/webaudio/AudioBufferSourceNode.cpp View 1 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
fs
Spotted via https://codereview.chromium.org/224833002/. The change to the nullable (getter) might be a bit on the ...
6 years, 8 months ago (2014-04-04 17:10:03 UTC) #1
Justin Novosad
lgtm for Source/core/html/canvas and the related test result change.
6 years, 8 months ago (2014-04-04 20:12:05 UTC) #2
acolwell GONE FROM CHROMIUM
lgtm Source/core/html/HTMLMediaElement.idl https://codereview.chromium.org/226073003/diff/20001/Source/core/html/HTMLMediaElement.idl File Source/core/html/HTMLMediaElement.idl (right): https://codereview.chromium.org/226073003/diff/20001/Source/core/html/HTMLMediaElement.idl#newcode32 Source/core/html/HTMLMediaElement.idl:32: readonly attribute MediaError error; nit: Make this ...
6 years, 8 months ago (2014-04-04 23:51:06 UTC) #3
haraken
LGTM for bindings/. https://codereview.chromium.org/226073003/diff/20001/Source/bindings/scripts/v8_attributes.py File Source/bindings/scripts/v8_attributes.py (right): https://codereview.chromium.org/226073003/diff/20001/Source/bindings/scripts/v8_attributes.py#newcode202 Source/bindings/scripts/v8_attributes.py:202: arguments.append('isNull') nbarth: We should remove |isNull| ...
6 years, 8 months ago (2014-04-05 02:10:49 UTC) #4
Ken Russell (switch to Gerrit)
rtoy@ should review the WebAudio changes.
6 years, 8 months ago (2014-04-05 21:32:55 UTC) #5
fs
https://codereview.chromium.org/226073003/diff/20001/Source/core/html/HTMLMediaElement.idl File Source/core/html/HTMLMediaElement.idl (right): https://codereview.chromium.org/226073003/diff/20001/Source/core/html/HTMLMediaElement.idl#newcode32 Source/core/html/HTMLMediaElement.idl:32: readonly attribute MediaError error; On 2014/04/04 23:51:07, acolwell_OOO_4-6_to_4-10 wrote: ...
6 years, 8 months ago (2014-04-07 11:36:15 UTC) #6
Nils Barth (inactive)
LGTM as well (bindings); thanks!
6 years, 8 months ago (2014-04-07 11:41:37 UTC) #7
Nils Barth (inactive)
https://codereview.chromium.org/226073003/diff/20001/Source/bindings/scripts/v8_attributes.py File Source/bindings/scripts/v8_attributes.py (right): https://codereview.chromium.org/226073003/diff/20001/Source/bindings/scripts/v8_attributes.py#newcode202 Source/bindings/scripts/v8_attributes.py:202: arguments.append('isNull') On 2014/04/05 02:10:50, haraken wrote: > nbarth: We ...
6 years, 8 months ago (2014-04-07 11:44:26 UTC) #8
fs
On 2014/04/05 21:32:55, Ken Russell wrote: > rtoy@ should review the WebAudio changes. rtoy: Ping?
6 years, 8 months ago (2014-04-07 16:21:12 UTC) #9
Raymond Toy
On 2014/04/07 16:21:12, fs wrote: > On 2014/04/05 21:32:55, Ken Russell wrote: > > rtoy@ ...
6 years, 8 months ago (2014-04-07 16:26:24 UTC) #10
fs
The CQ bit was checked by fs@opera.com
6 years, 8 months ago (2014-04-08 08:45:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/226073003/40001
6 years, 8 months ago (2014-04-08 08:45:36 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-04-08 08:57:39 UTC) #13
Message was sent while issue was closed. 
Change committed as 171043

Powered by Google App Engine
This is Rietveld 408576698