Source/core/html/HTMLMediaElement.idl - Issue 226073003: Fix StrictTypeChecking on interface type attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLMediaElement.idl

Issue 226073003: Fix StrictTypeChecking on interface type attributes (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Mark HTMLMediaElement.error nullable. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLMediaElement.idl

diff --git a/Source/core/html/HTMLMediaElement.idl b/Source/core/html/HTMLMediaElement.idl

index 55095b57d072b3d5220f58146987080f3aa641e7..20d3bdd8559f61b8e7386365692c04b7da68da6e 100644

--- a/Source/core/html/HTMLMediaElement.idl

+++ b/Source/core/html/HTMLMediaElement.idl

@@ -29,7 +29,7 @@

] interface HTMLMediaElement : HTMLElement {

// error state

- readonly attribute MediaError error;

+ [StrictTypeChecking] readonly attribute MediaError? error;

// network state

[Reflect, URL, PerWorldBindings, ActivityLogging=SetterForIsolatedWorlds] attribute DOMString src;

@@ -73,7 +73,7 @@

// media controller

[Reflect] attribute DOMString mediaGroup;

- [StrictTypeChecking] attribute MediaController controller;

+ [StrictTypeChecking] attribute MediaController? controller;

// controls

attribute boolean controls;