Source/bindings/scripts/v8_attributes.py - Issue 226073003: Fix StrictTypeChecking on interface type attributes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_attributes.py

Issue 226073003: Fix StrictTypeChecking on interface type attributes (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Mark HTMLMediaElement.error nullable. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/v8_attributes.py

diff --git a/Source/bindings/scripts/v8_attributes.py b/Source/bindings/scripts/v8_attributes.py

index b16b5b7435a9f34a6f8ccd54b25a4c880074034e..a6a89893bb5bcaec2506316fdbe9df255ec40516 100644

--- a/Source/bindings/scripts/v8_attributes.py

+++ b/Source/bindings/scripts/v8_attributes.py

@@ -198,7 +198,7 @@ def getter_expression(interface, attribute, contents):

if ('ImplementedBy' in attribute.extended_attributes and

not attribute.is_static):

arguments.append('*impl')

- if attribute.idl_type.is_nullable:

+ if attribute.idl_type.is_nullable and not contents['has_strict_type_checking']:

arguments.append('isNull')

if contents['is_getter_raises_exception']:

arguments.append('exceptionState')