Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2260573004: Reland of aise gyp/GN failure if proprietary_codecs=1 and ffmpeg_branding=Chromium (Closed)

Created:
4 years, 4 months ago by DaleCurtis
Modified:
4 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of aise gyp/GN failure if proprietary_codecs=1 and ffmpeg_branding=Chromium (patchset #1 id:1 of https://codereview.chromium.org/2260523002/ ) Reason for revert: Should be fixed by https://codereview.chromium.org/2260893002 Original issue's description: > Revert of Raise gyp/GN failure if proprietary_codecs=1 and ffmpeg_branding=Chromium (patchset #2 id:20001 of https://codereview.chromium.org/1569053002/ ) > > Reason for revert: > Failures on https://build.chromium.org/p/chromium.fyi/buildslaves/slave43-c1 > > Original issue's description: > > Raise gyp/GN failure if proprietary_codecs=1 and ffmpeg_branding=Chromium > > > > Otherwise Chromium claims supporting video/mp4 and fails to play some > > YouTube video without falling back to video/webm even if supported by > > the server. > > > > BUG=571417 > > > > R=jrummell@chromium.org > > > > Committed: https://crrev.com/8f897728330ab4afe8c449001386756a9895bcf7 > > Cr-Commit-Position: refs/heads/master@{#412760} > > TBR=dalecurtis@chromium.org,jrummell@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=571417 > > Committed: https://crrev.com/208cb0cd3a4126cca32286ee9afbb7597bf03e08 > Cr-Commit-Position: refs/heads/master@{#412831} TBR=jrummell@chromium.org,inferno@chromium.org,j.isorce@samsung.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=571417 Committed: https://crrev.com/f0131b657ac73731cd2f7c69caf0fbded721bb08 Cr-Commit-Position: refs/heads/master@{#413296}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M media/BUILD.gn View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
DaleCurtis
Created Reland of aise gyp/GN failure if proprietary_codecs=1 and ffmpeg_branding=Chromium
4 years, 4 months ago (2016-08-19 22:22:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2260573004/1
4 years, 4 months ago (2016-08-19 22:23:57 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-20 00:39:13 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-20 00:42:28 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0131b657ac73731cd2f7c69caf0fbded721bb08
Cr-Commit-Position: refs/heads/master@{#413296}

Powered by Google App Engine
This is Rietveld 408576698