Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2260893002: Fix libfuzzer configurations to actually use proprietary codecs. (Closed)

Created:
4 years, 4 months ago by DaleCurtis
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke, inferno
CC:
chromium-reviews, mmoroz, Oliver Chang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix libfuzzer configurations to actually use proprietary codecs. These configurations were configuring proprietary codecs without actually setting ffmpeg up for such support, so they were not testing everything they could be. Note: There was a duplicate config for gn_release_libfuzzer_asan, so I just changed it to be mac only (which doesn't have a ChromeOS codec configuration for ffmpeg). The choice of chromeos for the linux variants allows more coverage of codecs we ship across the breadth of linux based platforms. BUG=571417, 638935 TEST=mb_unittest Committed: https://crrev.com/ded04b8261c21b7a0a968c5f3cdd404c27e4131e Cr-Commit-Position: refs/heads/master@{#413260}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M tools/mb/mb_config.pyl View 4 chunks +12 lines, -10 lines 1 comment Download

Messages

Total messages: 10 (3 generated)
DaleCurtis
4 years, 4 months ago (2016-08-19 17:16:45 UTC) #2
inferno
4 years, 4 months ago (2016-08-19 17:58:47 UTC) #3
inferno
lgtm. thanks a lot for fixing this.
4 years, 4 months ago (2016-08-19 18:00:43 UTC) #4
Dirk Pranke
lgtm, thanks for fixing! https://codereview.chromium.org/2260893002/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2260893002/diff/1/tools/mb/mb_config.pyl#newcode2358 tools/mb/mb_config.pyl:2358: # chrome_with_codecs or chromeos_with_codecs mixins. ...
4 years, 4 months ago (2016-08-19 20:18:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2260893002/1
4 years, 4 months ago (2016-08-19 20:35:46 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-19 22:00:49 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 22:02:09 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ded04b8261c21b7a0a968c5f3cdd404c27e4131e
Cr-Commit-Position: refs/heads/master@{#413260}

Powered by Google App Engine
This is Rietveld 408576698