Issue 2260563002: Fixing headset unplug issues in MediaNotification

Issue 2260563002: Fixing headset unplug issues in MediaNotification (Closed)

Created:
4 years, 4 months ago by Zhiqiang Zhang (Slow)

Modified:
4 years, 4 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2785

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fixing headset unplug issues in MediaNotification This CL make MediaNotification fire a ACTION_STOP PendingIntent when the notification is dismissed, making the MediaSession inactive. Also, MediaNotification will not call play()/pause() when the notification is already in that state, preventing calling pause() when unpluging headset when the notification is already in paused state. An unplug-related UMA issue is also fixed in this CL. BUG=638858 Review-Url: https://codereview.chromium.org/2253293004 Cr-Commit-Position: refs/heads/master@{#412829} (cherry picked from commit e03e8ee0fc359e38700001f04b7ec2e9a01f5f52)

Patch Set 1 #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java	View		2 chunks	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Zhiqiang Zhang (Slow)

Committed patchset #1 (id:1) to pending queue manually as 9362f358fd3f2456a71547e54bf4bafbc803246f.

4 years, 4 months ago (2016-08-18 15:43:14 UTC) #1

Zhiqiang Zhang (Slow)

*Manually post* Patch has landed as: Fixing headset unplug issues in MediaNotification This CL make ...

4 years, 4 months ago (2016-08-19 11:20:19 UTC) #2

Zhiqiang Zhang (Slow)

4 years, 4 months ago (2016-08-19 11:21:54 UTC) #3

Message was sent while issue was closed.

On 2016/08/19 11:20:19, Zhiqiang Zhang wrote:
> *Manually post*
> 
> Patch has landed as:
> 
> Fixing headset unplug issues in MediaNotification
> 
> This CL make MediaNotification fire a ACTION_STOP PendingIntent when the
> notification is dismissed, making the MediaSession inactive.
> 
> Also, MediaNotification will not call play()/pause() when the
> notification is already in that state, preventing calling pause() when
> unpluging headset when the notification is already in paused state.
> 
> An unplug-related UMA issue is also fixed in this CL.
> 
> BUG=638858
> 
> Review-Url: https://codereview.chromium.org/2253293004
> Cr-Commit-Position: refs/heads/master@{#412829}
> (cherry picked from commit e03e8ee0fc359e38700001f04b7ec2e9a01f5f52)
> 
> Review URL: https://codereview.chromium.org/2260563002 .

commit# 9362f358fd3f2456a71547e54bf4bafbc803246f

Expand Messages | Collapse Messages