Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 2253293004: Fixing headset unplug issues in MediaNotification (Closed)

Created:
4 years, 4 months ago by Zhiqiang Zhang (Slow)
Modified:
4 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing headset unplug issues in MediaNotification This CL make MediaNotification fire a ACTION_STOP PendingIntent when the notification is dismissed, making the MediaSession inactive. Also, MediaNotification will not call play()/pause() when the notification is already in that state, preventing calling pause() when unpluging headset when the notification is already in paused state. An unplug-related UMA issue is also fixed in this CL. BUG=638858 Committed: https://crrev.com/e03e8ee0fc359e38700001f04b7ec2e9a01f5f52 Cr-Commit-Position: refs/heads/master@{#412829}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Zhiqiang Zhang (Slow)
4 years, 4 months ago (2016-08-18 13:21:23 UTC) #4
mlamouri (slow - plz ping)
lgtm
4 years, 4 months ago (2016-08-18 13:38:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2253293004/1
4 years, 4 months ago (2016-08-18 13:41:20 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 15:01:37 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 15:04:52 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e03e8ee0fc359e38700001f04b7ec2e9a01f5f52
Cr-Commit-Position: refs/heads/master@{#412829}

Powered by Google App Engine
This is Rietveld 408576698