Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issue 2260523002: Revert of Raise gyp/GN failure if proprietary_codecs=1 and ffmpeg_branding=Chromium (Closed)

Created:
4 years, 4 months ago by Julien Isorce Samsung
Modified:
4 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Raise gyp/GN failure if proprietary_codecs=1 and ffmpeg_branding=Chromium (patchset #2 id:20001 of https://codereview.chromium.org/1569053002/ ) Reason for revert: Failures on https://build.chromium.org/p/chromium.fyi/buildslaves/slave43-c1 Original issue's description: > Raise gyp/GN failure if proprietary_codecs=1 and ffmpeg_branding=Chromium > > Otherwise Chromium claims supporting video/mp4 and fails to play some > YouTube video without falling back to video/webm even if supported by > the server. > > BUG=571417 > > R=jrummell@chromium.org > > Committed: https://crrev.com/8f897728330ab4afe8c449001386756a9895bcf7 > Cr-Commit-Position: refs/heads/master@{#412760} TBR=dalecurtis@chromium.org,jrummell@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=571417 Committed: https://crrev.com/208cb0cd3a4126cca32286ee9afbb7597bf03e08 Cr-Commit-Position: refs/heads/master@{#412831}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M media/BUILD.gn View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Julien Isorce Samsung
Created Revert of Raise gyp/GN failure if proprietary_codecs=1 and ffmpeg_branding=Chromium
4 years, 4 months ago (2016-08-18 14:30:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2260523002/1
4 years, 4 months ago (2016-08-18 14:30:29 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-18 14:30:31 UTC) #5
inferno
lgtm
4 years, 4 months ago (2016-08-18 15:11:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2260523002/1
4 years, 4 months ago (2016-08-18 15:12:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 15:13:01 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/208cb0cd3a4126cca32286ee9afbb7597bf03e08 Cr-Commit-Position: refs/heads/master@{#412831}
4 years, 4 months ago (2016-08-18 15:14:14 UTC) #12
DaleCurtis
4 years, 4 months ago (2016-08-19 22:22:49 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2260573004/ by dalecurtis@chromium.org.

The reason for reverting is: Should be fixed by
https://codereview.chromium.org/2260893002.

Powered by Google App Engine
This is Rietveld 408576698