Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2260443003: [Offline Pages] Clean up some constant value types for proposed_offline_id arg. (Closed)

Created:
4 years, 4 months ago by dougarnett
Modified:
4 years, 3 months ago
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline Pages] Clean up some constant value types for proposed_offline_id arg. BUG=610521 Committed: https://crrev.com/21866a084bd701636a4756a430770a989b20398d Cr-Commit-Position: refs/heads/master@{#415060}

Patch Set 1 #

Patch Set 2 : Merge #

Messages

Total messages: 18 (12 generated)
dougarnett
4 years, 4 months ago (2016-08-19 01:31:00 UTC) #6
Pete Williamson
lgtm
4 years, 3 months ago (2016-08-23 17:51:48 UTC) #8
fgorski
On 2016/08/23 17:51:48, Pete Williamson wrote: > lgtm please hold of with checking in. This ...
4 years, 3 months ago (2016-08-23 18:00:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2260443003/20001
4 years, 3 months ago (2016-08-29 18:24:03 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-30 03:51:13 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 03:52:55 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/21866a084bd701636a4756a430770a989b20398d
Cr-Commit-Position: refs/heads/master@{#415060}

Powered by Google App Engine
This is Rietveld 408576698