chrome/browser/android/offline_pages/offline_page_utils_unittest.cc - Issue 2260443003: [Offline Pages] Clean up some constant value types for proposed_offline_id arg.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/offline_page_utils_unittest.cc

Issue 2260443003: [Offline Pages] Clean up some constant value types for proposed_offline_id arg. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc ('k') | chrome/browser/android/offline_pages/recent_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/offline_page_utils_unittest.cc

diff --git a/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc b/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc

index 8fd2532a134fd9e1b3d2aab4787e03c3fcb83fd0..2955b62cbe330a2ab8a23a8a3c649b559c43b1ca 100644

--- a/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc

+++ b/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc

@@ -156,7 +156,7 @@ void OfflinePageUtilsTest::CreateOfflinePages() {

client_id.name_space = kBookmarkNamespace;

client_id.id = kTestPage1ClientId;

model->SavePage(

- kTestPage1Url, client_id, 0ul, std::move(archiver),

+ kTestPage1Url, client_id, 0l, std::move(archiver),

base::Bind(&OfflinePageUtilsTest::OnSavePageDone, AsWeakPtr()));

RunUntilIdle();

offline_url_page_1_ =

@@ -167,7 +167,7 @@ void OfflinePageUtilsTest::CreateOfflinePages() {

base::FilePath(FILE_PATH_LITERAL("page2.mhtml")));

client_id.id = kTestPage2ClientId;

model->SavePage(

- kTestPage2Url, client_id, 0ul, std::move(archiver),

+ kTestPage2Url, client_id, 0l, std::move(archiver),

base::Bind(&OfflinePageUtilsTest::OnSavePageDone, AsWeakPtr()));

RunUntilIdle();

offline_url_page_2_ =

@@ -186,7 +186,7 @@ void OfflinePageUtilsTest::CreateOfflinePages() {

base::FilePath(FILE_PATH_LITERAL("page4.mhtml")));

client_id.id = kTestPage4ClientId;

model->SavePage(

- kTestPage4Url, client_id, 0ul, std::move(archiver),

+ kTestPage4Url, client_id, 0l, std::move(archiver),

base::Bind(&OfflinePageUtilsTest::OnSavePageDone, AsWeakPtr()));

RunUntilIdle();

const OfflinePageItem* page_4 = model->MaybeGetPageByOfflineId(offline_id());