components/offline_pages/offline_page_model_impl.cc - Issue 2260443003: [Offline Pages] Clean up some constant value types for proposed_offline_id arg.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/offline_page_model_impl.cc

Issue 2260443003: [Offline Pages] Clean up some constant value types for proposed_offline_id arg. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Merge Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/recent_tab_helper.cc ('k') | components/offline_pages/offline_page_model_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/offline_page_model_impl.cc

diff --git a/components/offline_pages/offline_page_model_impl.cc b/components/offline_pages/offline_page_model_impl.cc

index 806d4f0c7f803b5948766ff896c99496a2a843de..25f2e08a68de91249597a5a83ee048cdcde3bb42 100644

--- a/components/offline_pages/offline_page_model_impl.cc

+++ b/components/offline_pages/offline_page_model_impl.cc

@@ -296,7 +296,7 @@ void OfflinePageModelImpl::SavePage(

}

// If we already have an offline id, use it. If not, generate one.

- if (proposed_offline_id == 0ul)

+ if (proposed_offline_id == 0l)

proposed_offline_id = GenerateOfflineId();

archiver->CreateArchive(