Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 22604002: [SVG] Interval should not be created if a value in begin-value-list doesn't have a matching value i… (Closed)

Created:
7 years, 4 months ago by pavane
Modified:
7 years, 3 months ago
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), eae+blinkwatch, dglazkov+blink, dstockwell, Timothy Loh, f(malita), darktears, pdr, Stephen Chennney, Steve Block, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[SVG] Interval should not be created if a value in begin-value-list doesn't have a matching value in end-value-list In the pseudo code in http://www.w3.org/TR/SMIL3/smil-timing.html#q90 , it says that if all ends are before the current begin, then it is a bad interval and current begin will be discarded. Existing code is treating it as a vaild interval with end as indefinite. Modified the logic to be in line with the pseudo code. R=pdr@chromium.org, schenney@chromium.org, dschulze@chromium.org, fmalita@chromium.org BUG=269059 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157739

Patch Set 1 #

Patch Set 2 : rebaselined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -5 lines) Patch
A LayoutTests/svg/animations/animate-no-matching-end-value.html View 1 chunk +14 lines, -0 lines 0 comments Download
A LayoutTests/svg/animations/animate-no-matching-end-value-expected.txt View 1 1 chunk +24 lines, -0 lines 0 comments Download
A LayoutTests/svg/animations/resources/animate-no-matching-end-value.svg View 1 1 chunk +10 lines, -0 lines 0 comments Download
A LayoutTests/svg/animations/script-tests/animate-no-matching-end-value.js View 1 1 chunk +33 lines, -0 lines 0 comments Download
M Source/core/svg/animation/SVGSMILElement.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/animation/SVGSMILElement.cpp View 1 4 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pavane
WIP patch. Please have a look at this patch. I am having nightmares writing layout ...
7 years, 4 months ago (2013-08-08 19:09:11 UTC) #1
pavane
Please have a look at this patch
7 years, 3 months ago (2013-09-13 00:52:18 UTC) #2
pdr.
LGTM
7 years, 3 months ago (2013-09-13 05:15:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavan.e@samsung.com/22604002/4001
7 years, 3 months ago (2013-09-13 06:08:31 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-13 07:16:00 UTC) #5
Message was sent while issue was closed.
Change committed as 157739

Powered by Google App Engine
This is Rietveld 408576698