Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 22706003: [SVG] Handle beginEvent for svg animations (Closed)

Created:
7 years, 4 months ago by pavane
Modified:
7 years, 3 months ago
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), eae+blinkwatch, dglazkov+blink, dstockwell, Timothy Loh, f(malita), darktears, pdr, Stephen Chennney, Steve Block, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -2 lines) Patch
A LayoutTests/svg/animations/begin-event.svg View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
A LayoutTests/svg/animations/begin-event-expected.svg View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/svg/animation/SVGSMILElement.cpp View 1 2 5 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
pavane
WIP patch, Please have a look. Facing problem with writing layout tests, please help. I ...
7 years, 4 months ago (2013-08-08 19:11:09 UTC) #1
pavane
Please have a look at this patch
7 years, 3 months ago (2013-08-30 20:47:41 UTC) #2
pdr.
LGTM with nits. Feel free to land this once you update the test. https://codereview.chromium.org/22706003/diff/6001/LayoutTests/svg/animations/begin-event.svg File ...
7 years, 3 months ago (2013-08-30 20:50:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pavan.e@samsung.com/22706003/12001
7 years, 3 months ago (2013-08-30 21:00:52 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-08-30 23:17:47 UTC) #5
Message was sent while issue was closed.
Change committed as 157026

Powered by Google App Engine
This is Rietveld 408576698