Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 2260343002: Revert of Show the Cast toolbar icon ephemerally when Cast is in use (Closed)

Created:
4 years, 4 months ago by takumif
Modified:
4 years, 4 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, media-router+watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Show the Cast toolbar icon ephemerally when Cast is in use (patchset #15 id:440001 of https://codereview.chromium.org/2155293002/ ) Reason for revert: Reverting this CL since it is causing crashes and needs a redesign. Also reverting a related CL: https://codereview.chromium.org/2260873003/ Original issue's description: > Show the Cast toolbar icon ephemerally when Cast is in use > > This CL changes the behavior of the Cast/Media Router toolbar component > action icon. Currently, the only way to add the icon is by installing > the Cast extension from the Web Store. After this change, the icon will > be displayed temporarily whenever the Media Router dialog is open, or there > is an active local media route. > > This CL also replaces the "Remove icon" option in the action context menu > with "Always show icon" which can be checked. When this option is unchecked, > the icon is neither on the toolbar nor in the overflow menu, and is only shown > ephemerally in the situations mentioned above. > > We replace the word "popup" with "dialog" wherever possible in > MediaRouterAction, to stay consistent with the rest of Media Router files. > > We also change the default position of the component actions on the toolbar > from the leftmost to the rightmost (same behavior as extension actions). > > TBR=grt@chromium.org > BUG=594577 > > Committed: https://crrev.com/de716ca8b6cffb4c7ae30990b3288b3499d28a4c > Cr-Commit-Position: refs/heads/master@{#412280} TBR=anthonyvd@chromium.org,apacible@chromium.org,msw@chromium.org,rdevlin.cronin@chromium.org,mfoltz@chromium.org,grt@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=594577 Committed: https://crrev.com/3b3841e82bec9ffa674ba6596834ef4db2c95481 Cr-Commit-Position: refs/heads/master@{#413338}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+168 lines, -453 lines) Patch
M chrome/app/chrome_command_ids.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/media_router_strings.grdp View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/component_migration_helper.cc View 4 chunks +0 lines, -20 lines 0 comments Download
M chrome/browser/extensions/component_migration_helper_unittest.cc View 4 chunks +0 lines, -39 lines 0 comments Download
M chrome/browser/profiles/profile.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/toolbar/component_toolbar_actions_factory.cc View 3 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/ui/toolbar/media_router_action.h View 6 chunks +7 lines, -32 lines 0 comments Download
M chrome/browser/ui/toolbar/media_router_action.cc View 8 chunks +35 lines, -81 lines 0 comments Download
M chrome/browser/ui/toolbar/media_router_action_unittest.cc View 8 chunks +30 lines, -148 lines 0 comments Download
M chrome/browser/ui/toolbar/media_router_contextual_menu.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/toolbar/media_router_contextual_menu.cc View 6 chunks +19 lines, -22 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_actions_model.h View 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_actions_model.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc View 3 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl.h View 4 chunks +2 lines, -19 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl.cc View 12 chunks +25 lines, -57 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 23 (16 generated)
takumif
Created Revert of Show the Cast toolbar icon ephemerally when Cast is in use
4 years, 4 months ago (2016-08-19 22:15:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2260343002/1
4 years, 4 months ago (2016-08-19 22:16:24 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-19 22:16:26 UTC) #5
mark a. foltz
lgtm
4 years, 4 months ago (2016-08-19 22:31:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2260343002/1
4 years, 4 months ago (2016-08-20 15:29:12 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-20 15:34:22 UTC) #21
commit-bot: I haz the power
4 years, 4 months ago (2016-08-20 15:35:57 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b3841e82bec9ffa674ba6596834ef4db2c95481
Cr-Commit-Position: refs/heads/master@{#413338}

Powered by Google App Engine
This is Rietveld 408576698