chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc - Issue 2260343002: Revert of Show the Cast toolbar icon ephemerally when Cast is in use

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc

Issue 2260343002: Revert of Show the Cast toolbar icon ephemerally when Cast is in use (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc ('k') | chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc

diff --git a/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc b/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc

index 7a7bb6a50e5b2d6141ba92f4846a320ea07184cd..217be79cf992a5d1a5640da70cb04aca07a93366 100644

--- a/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc

+++ b/chrome/browser/ui/views/media_router/media_router_ui_browsertest.cc

@@ -8,7 +8,6 @@

#include "chrome/browser/ui/browser.h"

#include "chrome/browser/ui/browser_commands.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

-#include "chrome/browser/ui/toolbar/component_toolbar_actions_factory.h"

#include "chrome/browser/ui/toolbar/media_router_action.h"

#include "chrome/browser/ui/toolbar/toolbar_action_view_delegate.h"

#include "chrome/browser/ui/views/frame/browser_view.h"

@@ -44,8 +43,6 @@

false));

media_router_action_.reset(new MediaRouterAction(browser(),

browser_action_test_util_->GetToolbarActionsBar()));

- // Toggle the "always show" setting on.

- media_router_action_->ToggleVisibilityPreference();

toolbar_action_view_widget_ = new views::Widget();

views::Widget::InitParams params(views::Widget::InitParams::TYPE_POPUP);

@@ -61,8 +58,6 @@

void TearDownOnMainThread() override {

toolbar_action_view_widget_->Close();

- // Toggle the "always show" setting off.

- media_router_action_->ToggleVisibilityPreference();

media_router_action_.reset();

browser_action_test_util_.reset();

InProcessBrowserTest::TearDownOnMainThread();