Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3244)

Unified Diff: chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc

Issue 2260343002: Revert of Show the Cast toolbar icon ephemerally when Cast is in use (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc
diff --git a/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc b/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc
index dbb66e5e324f9e620bb842b8729406e6aaf1578d..a4bbd98b39ed1fe0cd82031bee7b6399578d1b0e 100644
--- a/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc
+++ b/chrome/browser/ui/toolbar/toolbar_actions_model_unittest.cc
@@ -1308,6 +1308,36 @@
observer()->inserted_count() - observer()->removed_count());
}
+TEST_F(ToolbarActionsModelUnitTest, ComponentExtensionsAddedToEnd) {
+ Init();
+
+ ASSERT_TRUE(AddBrowserActionExtensions());
+
+ EXPECT_EQ(browser_action_a()->id(), GetActionIdAtIndex(0));
+ EXPECT_EQ(browser_action_b()->id(), GetActionIdAtIndex(1));
+ EXPECT_EQ(browser_action_c()->id(), GetActionIdAtIndex(2));
+
+ const char kName[] = "component";
+ extensions::DictionaryBuilder manifest;
+ manifest.Set("name", kName)
+ .Set("description", "An extension")
+ .Set("manifest_version", 2)
+ .Set("version", "1.0.0")
+ .Set("browser_action", extensions::DictionaryBuilder().Build());
+ scoped_refptr<const extensions::Extension> component_extension =
+ extensions::ExtensionBuilder()
+ .SetManifest(manifest.Build())
+ .SetID(crx_file::id_util::GenerateId(kName))
+ .SetLocation(extensions::Manifest::COMPONENT)
+ .Build();
+ service()->AddExtension(component_extension.get());
+
+ EXPECT_EQ(component_extension.get()->id(), GetActionIdAtIndex(0));
+ EXPECT_EQ(browser_action_a()->id(), GetActionIdAtIndex(1));
+ EXPECT_EQ(browser_action_b()->id(), GetActionIdAtIndex(2));
+ EXPECT_EQ(browser_action_c()->id(), GetActionIdAtIndex(3));
+}
+
// Test various different reorderings, removals, and reinsertions of the
// toolbar with component actions.
TEST_F(ToolbarActionsModelUnitTest,

Powered by Google App Engine
This is Rietveld 408576698