Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2260133003: Change the host_debug sky_shell used for testing to build with assertions enabled (Closed)

Created:
4 years, 4 months ago by jsimmons1
Modified:
4 years, 4 months ago
Reviewers:
abarth, Chinmay, eseidel
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Change the host_debug sky_shell used for testing to build with assertions enabled BUG= Committed: https://chromium.googlesource.com/chromium/tools/build/+/814cb05c7b410646c0e58e4c3e2dfd697a03d96c

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -22 lines) Patch
M scripts/slave/recipes/flutter/engine.py View 2 chunks +11 lines, -11 lines 1 comment Download
M scripts/slave/recipes/flutter/engine.expected/linux.json View 3 chunks +7 lines, -6 lines 1 comment Download
M scripts/slave/recipes/flutter/engine.expected/mac.json View 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
jsimmons1
4 years, 4 months ago (2016-08-19 19:30:46 UTC) #3
Chinmay
lgtm
4 years, 4 months ago (2016-08-19 19:43:48 UTC) #5
eseidel
lgtm https://codereview.chromium.org/2260133003/diff/1/scripts/slave/recipes/flutter/engine.expected/linux.json File scripts/slave/recipes/flutter/engine.expected/linux.json (right): https://codereview.chromium.org/2260133003/diff/1/scripts/slave/recipes/flutter/engine.expected/linux.json#newcode145 scripts/slave/recipes/flutter/engine.expected/linux.json:145: "name": "gn --unoptimized (2)" When names are not ...
4 years, 4 months ago (2016-08-19 19:44:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2260133003/1
4 years, 4 months ago (2016-08-19 19:44:53 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 19:49:08 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/814cb05c7b410646c0e5...

Powered by Google App Engine
This is Rietveld 408576698