Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1221)

Unified Diff: scripts/slave/recipes/flutter/engine.py

Issue 2260133003: Change the host_debug sky_shell used for testing to build with assertions enabled (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/flutter/engine.py
diff --git a/scripts/slave/recipes/flutter/engine.py b/scripts/slave/recipes/flutter/engine.py
index f2607963fb3a85c413df4d95166e57befe7edd72..3facfb6ee636ab2bdb39ff9aad96abac21bc1d4d 100644
--- a/scripts/slave/recipes/flutter/engine.py
+++ b/scripts/slave/recipes/flutter/engine.py
@@ -160,18 +160,18 @@ def BuildLinuxAndroidArm(api):
def BuildLinux(api):
- RunGN(api)
- Build(api, 'host_debug')
+ RunGN(api, '--unoptimized')
eseidel 2016/08/19 19:44:40 We should probably pass some sort of name to RunGN
+ Build(api, 'host_debug_unopt')
UploadArtifacts(api, 'linux-x64', [
- 'out/host_debug/icudtl.dat',
- 'out/host_debug/sky_shell',
- 'out/host_debug/sky_snapshot',
+ 'out/host_debug_unopt/icudtl.dat',
+ 'out/host_debug_unopt/sky_shell',
+ 'out/host_debug_unopt/sky_snapshot',
])
def TestObservatory(api):
checkout = api.path['slave_build'].join('src')
- sky_shell_path = checkout.join('out/host_debug/sky_shell')
+ sky_shell_path = checkout.join('out/host_debug_unopt/sky_shell')
empty_main_path = \
checkout.join('flutter/sky/shell/testing/observatory/empty_main.dart')
test_path = checkout.join('flutter/sky/shell/testing/observatory/test.dart')
@@ -180,18 +180,18 @@ def TestObservatory(api):
def BuildMac(api):
- RunGN(api, '--runtime-mode', 'debug')
+ RunGN(api, '--runtime-mode', 'debug', '--unoptimized')
RunGN(api, '--runtime-mode', 'profile', '--android')
RunGN(api, '--runtime-mode', 'release', '--android')
- Build(api, 'host_debug')
+ Build(api, 'host_debug_unopt')
Build(api, 'android_profile', 'flutter/lib/snapshot')
Build(api, 'android_release', 'flutter/lib/snapshot')
UploadArtifacts(api, 'darwin-x64', [
- 'out/host_debug/sky_snapshot',
- 'out/host_debug/sky_shell',
- 'out/host_debug/icudtl.dat',
+ 'out/host_debug_unopt/sky_snapshot',
+ 'out/host_debug_unopt/sky_shell',
+ 'out/host_debug_unopt/icudtl.dat',
])
UploadArtifacts(api, "android-arm-profile" , [

Powered by Google App Engine
This is Rietveld 408576698