Change the host_debug sky_shell used for testing to build with assertions enabled

scripts/slave/recipes/flutter/engine.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import contextlib
 
 DEPS = [
   'depot_tools/bot_update',
   'depot_tools/gclient',
   'file',
@@ skipping 142 matching lines @@
     ], archive_name='linux-x64.zip')
     UploadArtifacts(api, upload_dir, [
         'out/%s/libsky_shell.so' % build_output_dir
     ], archive_name='symbols.zip')
 
   UploadDartPackage(api, 'sky_engine')
   UploadDartPackage(api, 'sky_services')
 
 
 def BuildLinux(api):
-  RunGN(api)
-  Build(api, 'host_debug')
+  RunGN(api, '--unoptimized')

[eseidel, 2016/08/19 19:44:40]

We should probably pass some sort of name to RunGN so it can make the name which
appears in the buildbot be unique.  But that can also be a later change.

+  Build(api, 'host_debug_unopt')
   UploadArtifacts(api, 'linux-x64', [
-    'out/host_debug/icudtl.dat',
-    'out/host_debug/sky_shell',
-    'out/host_debug/sky_snapshot',
+    'out/host_debug_unopt/icudtl.dat',
+    'out/host_debug_unopt/sky_shell',
+    'out/host_debug_unopt/sky_snapshot',
   ])
 
 
 def TestObservatory(api):
   checkout = api.path['slave_build'].join('src')
-  sky_shell_path = checkout.join('out/host_debug/sky_shell')
+  sky_shell_path = checkout.join('out/host_debug_unopt/sky_shell')
   empty_main_path = \
       checkout.join('flutter/sky/shell/testing/observatory/empty_main.dart')
   test_path = checkout.join('flutter/sky/shell/testing/observatory/test.dart')
   test_cmd = ['dart', test_path, sky_shell_path, empty_main_path]
   api.step('test observatory and service protocol', test_cmd, cwd=checkout)
 
 
 def BuildMac(api):
-  RunGN(api, '--runtime-mode', 'debug')
+  RunGN(api, '--runtime-mode', 'debug', '--unoptimized')
   RunGN(api, '--runtime-mode', 'profile', '--android')
   RunGN(api, '--runtime-mode', 'release', '--android')
 
-  Build(api, 'host_debug')
+  Build(api, 'host_debug_unopt')
   Build(api, 'android_profile', 'flutter/lib/snapshot')
   Build(api, 'android_release', 'flutter/lib/snapshot')
 
   UploadArtifacts(api, 'darwin-x64', [
-    'out/host_debug/sky_snapshot',
-    'out/host_debug/sky_shell',
-    'out/host_debug/icudtl.dat',
+    'out/host_debug_unopt/sky_snapshot',
+    'out/host_debug_unopt/sky_shell',
+    'out/host_debug_unopt/icudtl.dat',
   ])
 
   UploadArtifacts(api, "android-arm-profile" , [
     'out/android_profile/clang_i386/gen_snapshot',
   ], archive_name='darwin-x64.zip')
 
   UploadArtifacts(api, "android-arm-release" , [
     'out/android_release/clang_i386/gen_snapshot',
   ], archive_name='darwin-x64.zip')
 
@@ skipping 97 matching lines @@
       BuildIOS(api)
 
 
 def GenTests(api):
   # A valid commit to flutter/engine, to make the gsutil urls look real.
   for platform in ('mac', 'linux'):
     yield (api.test(platform) + api.platform(platform, 64)
         + api.properties(mastername='client.flutter',
               buildername='%s Engine' % platform.capitalize(),
               slavename='fake-m1', clobber=''))