Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2260083002: Register the window in MaximizeModeWindowManager when the window is shown. (Closed)

Created:
4 years, 4 months ago by oshima
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Register the window in MaximizeModeWindowManager when the window is shown. This is necessary for arc app to set the "don't manage me" flag. BUG=635899 Review-Url: https://codereview.chromium.org/2250963006 Cr-Commit-Position: refs/heads/master@{#412882} (cherry picked from commit 5ef3cfef16fad285e84d8655e592d522401b6ff8) Do not automatically maximize the window if the maximized bounds can be controlled by the client in Tablet mode (aka Maximized mode), which all arc windows are. The maximizing in tablet mode will be handled on arndroid side. BUG=635899 TEST=MaximizeModeWindowManagerTest.DontMaximizeClientManagedWindows Review-Url: https://codereview.chromium.org/2249953002 Cr-Commit-Position: refs/heads/master@{#412566} (cherry picked from commit cbd18684621964b72a64cc91775c89721cc07a4f) Committed: https://chromium.googlesource.com/chromium/src/+/9c37e2d02b59b912e8a4bf83c4a0f0259282d4db

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -3 lines) Patch
M ash/common/wm/maximize_mode/maximize_mode_window_manager.h View 3 chunks +6 lines, -2 lines 0 comments Download
M ash/common/wm/maximize_mode/maximize_mode_window_manager.cc View 4 chunks +37 lines, -1 line 0 comments Download

Messages

Total messages: 3 (2 generated)
oshima
4 years, 4 months ago (2016-08-19 00:54:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
9c37e2d02b59b912e8a4bf83c4a0f0259282d4db (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698