Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2249953002: Do not automatically maximize the window if the maximized bounds can be controlled by the client. (Closed)

Created:
4 years, 4 months ago by oshima
Modified:
4 years, 4 months ago
CC:
chromium-reviews, kalyank, sadrul, reveman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not automatically maximize the window if the maximized bounds can be controlled by the client in Tablet mode (aka Maximized mode), which all arc windows are. The maximizing in tablet mode will be handled on arndroid side. BUG=635899 TEST=MaximizeModeWindowManagerTest.DontMaximizeClientManagedWindows Committed: https://crrev.com/cbd18684621964b72a64cc91775c89721cc07a4f Cr-Commit-Position: refs/heads/master@{#412566}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M ash/common/wm/maximize_mode/maximize_mode_window_manager.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
oshima
4 years, 4 months ago (2016-08-16 19:17:58 UTC) #8
Mr4D (OOO till 08-26)
lgtm
4 years, 4 months ago (2016-08-16 21:04:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2249953002/20001
4 years, 4 months ago (2016-08-17 16:59:23 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 4 months ago (2016-08-17 17:04:00 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 17:07:36 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cbd18684621964b72a64cc91775c89721cc07a4f
Cr-Commit-Position: refs/heads/master@{#412566}

Powered by Google App Engine
This is Rietveld 408576698