Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: ash/common/wm/maximize_mode/maximize_mode_window_manager.h

Issue 2260083002: Register the window in MaximizeModeWindowManager when the window is shown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2785
Patch Set: . Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/common/wm/maximize_mode/maximize_mode_window_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/common/wm/maximize_mode/maximize_mode_window_manager.h
diff --git a/ash/common/wm/maximize_mode/maximize_mode_window_manager.h b/ash/common/wm/maximize_mode/maximize_mode_window_manager.h
index 7f066bead7317df097295962ed7bf31b7bf56c1a..b7ca3fa127e39693b17ef19eace96c21793232e5 100644
--- a/ash/common/wm/maximize_mode/maximize_mode_window_manager.h
+++ b/ash/common/wm/maximize_mode/maximize_mode_window_manager.h
@@ -8,7 +8,7 @@
#include <stdint.h>
#include <map>
-#include <set>
+#include <unordered_set>
#include "ash/ash_export.h"
#include "ash/common/shell_observer.h"
@@ -63,6 +63,7 @@ class ASH_EXPORT MaximizeModeWindowManager : public WmWindowObserver,
void OnWindowBoundsChanged(WmWindow* window,
const gfx::Rect& old_bounds,
const gfx::Rect& new_bounds) override;
+ void OnWindowVisibilityChanging(WmWindow* window, bool visible) override;
// display::DisplayObserver overrides:
void OnDisplayAdded(const display::Display& display) override;
@@ -122,7 +123,10 @@ class ASH_EXPORT MaximizeModeWindowManager : public WmWindowObserver,
WindowToState window_state_map_;
// All container windows which have to be tracked.
- std::set<WmWindow*> observed_container_windows_;
+ std::unordered_set<WmWindow*> observed_container_windows_;
+
+ // Windows added to the container, but not yet shown.
+ std::unordered_set<WmWindow*> added_windows_;
// True if all backdrops are hidden.
bool backdrops_hidden_;
« no previous file with comments | « no previous file | ash/common/wm/maximize_mode/maximize_mode_window_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698