|
[ARC] [Split this CL] Convert ios/web/webui to ARC.
Converts ios/web/webui to ARC.
Notable changes:
* ios/web/webui/crw_web_ui_page_builder.mm has a block that had a __block
reference to itself. Before ARC __block means "do not retain when
being captured in a block", but with ARC it is captured. So I added an
additional variable of __weak __block type instead.
* One WeakNSObject in mojo_facade.h could not be removed because it is
included from non-ARC code. WeakNSObject is functional in ARC but is not
preferred. Filed crbug.com/639326 to track future removal of this.
BUG= 639327
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+111 lines, -36 lines) |
Patch |
 |
M |
ios/web/BUILD.gn
|
View
|
|
5 chunks |
+64 lines, -26 lines |
0 comments
|
Download
|
 |
M |
ios/web/webui/crw_web_ui_manager.mm
|
View
|
|
3 chunks |
+5 lines, -2 lines |
0 comments
|
Download
|
 |
M |
ios/web/webui/crw_web_ui_page_builder.mm
|
View
|
|
6 chunks |
+14 lines, -8 lines |
0 comments
|
Download
|
 |
M |
ios/web/webui/mojo_facade.mm
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
ios/web/webui/shared_resources_data_source_ios.mm
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
ios/web/webui/url_data_manager_ios_backend.mm
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
ios/web/webui/url_data_source_ios.mm
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
ios/web/webui/url_fetcher_block_adapter.mm
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
ios/web/webui/web_ui_ios_data_source_impl.mm
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
 |
M |
ios/web/webui/web_ui_ios_impl.mm
|
View
|
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
Depends on Patchset:
Total messages: 4 (4 generated)
|