Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2260023004: [ARC] [Split this CL] Convert ios/web/webui to ARC. (Closed)

Created:
4 years, 4 months ago by stkhapugin
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ios-web-net
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ARC] [Split this CL] Convert ios/web/webui to ARC. Converts ios/web/webui to ARC. Notable changes: * ios/web/webui/crw_web_ui_page_builder.mm has a block that had a __block reference to itself. Before ARC __block means "do not retain when being captured in a block", but with ARC it is captured. So I added an additional variable of __weak __block type instead. * One WeakNSObject in mojo_facade.h could not be removed because it is included from non-ARC code. WeakNSObject is functional in ARC but is not preferred. Filed crbug.com/639326 to track future removal of this. BUG=639327

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -36 lines) Patch
M ios/web/BUILD.gn View 5 chunks +64 lines, -26 lines 0 comments Download
M ios/web/webui/crw_web_ui_manager.mm View 3 chunks +5 lines, -2 lines 0 comments Download
M ios/web/webui/crw_web_ui_page_builder.mm View 6 chunks +14 lines, -8 lines 0 comments Download
M ios/web/webui/mojo_facade.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/webui/shared_resources_data_source_ios.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/webui/url_data_manager_ios_backend.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/webui/url_data_source_ios.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/webui/url_fetcher_block_adapter.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/webui/web_ui_ios_data_source_impl.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/web/webui/web_ui_ios_impl.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 4 (4 generated)
stkhapugin
The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-19 16:52:26 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2260023004/1
4 years, 4 months ago (2016-08-19 16:52:53 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-19 17:54:53 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 17:54:54 UTC) #4
Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

Powered by Google App Engine
This is Rietveld 408576698