Converts ios/web/net to ARC.

Converts ios/web/net to ARC.

Converts files located in ios/web/net.

Removes property_releaser usage. Includes results of ARCMigrate run.
Replaces WeakNSObjects with __weak variables. Inserts compile guards.

Additionaly, renames ivars from trailing underscore to leading.

BUG=624365
TEST=None

Committed: https://crrev.com/752abca03af110f7641b17fc2153babc87a01ba9
Cr-Commit-Position: refs/heads/master@{#414417}

[stkhapugin, 2016-08-19 14:45:58]

Removes web_arc_transition temporary target

[stkhapugin, 2016-08-19 14:48:32]

stkhapugin@chromium.org changed reviewers:
+ eugenebut@chromium.org

[stkhapugin, 2016-08-19 14:48:32]

PTAL

[Eugene But (OOO till 7-30), 2016-08-19 15:34:32]

This change make 15 implementation files to use ARC. Could you please split your
CL to smaller chunks. So if we revert we revert just a few files. Reviewing 15
files at once may not be very efficient.

[Eugene But (OOO till 7-30), 2016-08-19 15:36:53]

F.e. you can land all C++ files in a single CL. But please split Objective-C
changes.

[stkhapugin, 2016-08-19 15:48:36]

On 2016/08/19 15:36:53, Eugene But wrote:
> F.e. you can land all C++ files in a single CL. But please split Objective-C
> changes.

I can split it even further. But I think the changes are mostly trivial, for
example here there are:
* 5 files that are just getting compile guards 
* 7 objective-c files with changes and 
* 1 BUILD.gn. 

Given that ios/web has 174 .mm files, at a rate of 12 .mm files per CL I will
generate 15 CLs. 

Also, hopefully, we are not going to revert them often! 
But if it is problematic to handle a CL this size, I will split into smaller
CLs. What CL size
would you like to see, in terms of .mm files count?

[Eugene But (OOO till 7-30), 2016-08-19 15:54:35]

On 2016/08/19 15:48:36, stkhapugin wrote:
> On 2016/08/19 15:36:53, Eugene But wrote:
> > F.e. you can land all C++ files in a single CL. But please split Objective-C
> > changes.
> 
> I can split it even further. But I think the changes are mostly trivial, for
> example here there are:
> * 5 files that are just getting compile guards 
> * 7 objective-c files with changes and 
> * 1 BUILD.gn. 
> 
> Given that ios/web has 174 .mm files, at a rate of 12 .mm files per CL I will
> generate 15 CLs. 
> 
> Also, hopefully, we are not going to revert them often! 
> But if it is problematic to handle a CL this size, I will split into smaller
> CLs. What CL size
> would you like to see, in terms of .mm files count?
I see your point. This CL though has 15 implementation files in web_arc target,
and all of them has to be reviewed.

Let me review this CL as it is and would be great if the future CLs will add up
to 10 files to web_arc target. Totally making this number up. 15 is a lot, but
less then 10 will just yield to many CLs.

[stkhapugin, 2016-08-19 15:57:44]

On 2016/08/19 15:54:35, Eugene But wrote:
> On 2016/08/19 15:48:36, stkhapugin wrote:
> > On 2016/08/19 15:36:53, Eugene But wrote:
> > > F.e. you can land all C++ files in a single CL. But please split
Objective-C
> > > changes.
> > 
> > I can split it even further. But I think the changes are mostly trivial, for
> > example here there are:
> > * 5 files that are just getting compile guards 
> > * 7 objective-c files with changes and 
> > * 1 BUILD.gn. 
> > 
> > Given that ios/web has 174 .mm files, at a rate of 12 .mm files per CL I
will
> > generate 15 CLs. 
> > 
> > Also, hopefully, we are not going to revert them often! 
> > But if it is problematic to handle a CL this size, I will split into smaller
> > CLs. What CL size
> > would you like to see, in terms of .mm files count?
> I see your point. This CL though has 15 implementation files in web_arc
target,
> and all of them has to be reviewed.
> 
> Let me review this CL as it is and would be great if the future CLs will add
up
> to 10 files to web_arc target. Totally making this number up. 15 is a lot, but
> less then 10 will just yield to many CLs.

No problem, I'll split into batches of 10. Each batch is a lot of work
*initially*,
 but I now realize that I can do it all at once and prepare a large CL, then
split 
it into many small ones instead of repeating the steps for each smaller batch.

[Eugene But (OOO till 7-30), 2016-08-19 15:58:30]

On 2016/08/19 15:54:35, Eugene But wrote:
> On 2016/08/19 15:48:36, stkhapugin wrote:
> > On 2016/08/19 15:36:53, Eugene But wrote:
> > > F.e. you can land all C++ files in a single CL. But please split
Objective-C
> > > changes.
> > 
> > I can split it even further. But I think the changes are mostly trivial, for
> > example here there are:
> > * 5 files that are just getting compile guards 
> > * 7 objective-c files with changes and 
> > * 1 BUILD.gn. 
> > 
> > Given that ios/web has 174 .mm files, at a rate of 12 .mm files per CL I
will
> > generate 15 CLs. 
> > 
> > Also, hopefully, we are not going to revert them often! 
> > But if it is problematic to handle a CL this size, I will split into smaller
> > CLs. What CL size
> > would you like to see, in terms of .mm files count?
> I see your point. This CL though has 15 implementation files in web_arc
target,
> and all of them has to be reviewed.
> 
> Let me review this CL as it is and would be great if the future CLs will add
up
> to 10 files to web_arc target. Totally making this number up. 15 is a lot, but
> less then 10 will just yield to many CLs.
Oh and please do our WebController god class in a single CL. I don't know how we
going to review it though :)

[Eugene But (OOO till 7-30), 2016-08-19 16:34:50]

We plan to remove most of this code. Should we even bother converting it and
have a rist of memory leaks?

https://codereview.chromium.org/2247303009/diff/20001/ios/web/BUILD.gn
File ios/web/BUILD.gn (right):

https://codereview.chromium.org/2247303009/diff/20001/ios/web/BUILD.gn#newcode87
ios/web/BUILD.gn:87: "net/request_group_util.mm",
This and all the files below are also request tracker code which we would like
to remove. Maybe we should not spend time on converting these?

https://codereview.chromium.org/2247303009/diff/20001/ios/web/net/clients/crw...
File ios/web/net/clients/crw_js_injection_network_client.mm (right):

https://codereview.chromium.org/2247303009/diff/20001/ios/web/net/clients/crw...
ios/web/net/clients/crw_js_injection_network_client.mm:16: #if
!defined(__has_feature) || !__has_feature(objc_arc)
We don't need network clients code with WKWebView. We plan to remove request
tracker and all networks clients at some point. This is not dead code though and
these will be used during sign in and can leak. With that maybe we should not
convert network clients code at all?

[stkhapugin, 2016-08-19 16:52:21]

The CQ bit was checked by stkhapugin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 16:52:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 18:05:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 18:05:00]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2016-08-19 20:05:08]

lgtm

[stkhapugin, 2016-08-25 11:58:24]

The CQ bit was checked by stkhapugin@chromium.org

[commit-bot: I haz the power, 2016-08-25 11:58:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 13:26:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-25 13:29:14]

Description was changed from

==========
Converts ios/web/net to ARC.

Converts files located in ios/web/net.

Removes property_releaser usage. Includes results of ARCMigrate run.
Replaces WeakNSObjects with __weak variables. Inserts compile guards.

Additionaly, renames ivars from trailing underscore to leading.

BUG=624365
TEST=None
==========

to

==========
Converts ios/web/net to ARC.

Converts files located in ios/web/net.

Removes property_releaser usage. Includes results of ARCMigrate run.
Replaces WeakNSObjects with __weak variables. Inserts compile guards.

Additionaly, renames ivars from trailing underscore to leading.

BUG=624365
TEST=None

Committed: https://crrev.com/752abca03af110f7641b17fc2153babc87a01ba9
Cr-Commit-Position: refs/heads/master@{#414417}
==========

[commit-bot: I haz the power, 2016-08-25 13:29:15]

Patchset 2 (id:??) landed as
https://crrev.com/752abca03af110f7641b17fc2153babc87a01ba9
Cr-Commit-Position: refs/heads/master@{#414417}