Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: ios/web/webui/crw_web_ui_manager.mm

Issue 2260023004: [ARC] [Split this CL] Convert ios/web/webui to ARC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ios-web-net
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/BUILD.gn ('k') | ios/web/webui/crw_web_ui_page_builder.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/webui/crw_web_ui_manager.mm
diff --git a/ios/web/webui/crw_web_ui_manager.mm b/ios/web/webui/crw_web_ui_manager.mm
index 8cee8d96ba05d2db1dd0ee10c7fc03dbc9632d9c..75a1d8e9de79553f4412d0a08d01f49a4a16cd17 100644
--- a/ios/web/webui/crw_web_ui_manager.mm
+++ b/ios/web/webui/crw_web_ui_manager.mm
@@ -25,6 +25,10 @@
#include "mojo/public/js/constants.h"
#import "net/base/mac/url_conversions.h"
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
namespace {
// Prefix for history.requestFavicon JavaScript message.
const char kScriptCommandPrefix[] = "webui";
@@ -98,7 +102,6 @@ const char kScriptCommandPrefix[] = "webui";
- (void)dealloc {
[self resetWebState];
- [super dealloc];
}
#pragma mark - CRWWebStateObserver Methods
@@ -214,7 +217,7 @@ const char kScriptCommandPrefix[] = "webui";
// Retrieve favicon resource and set favicon background image via JavaScript.
base::WeakNSObject<CRWWebUIManager> weakSelf(self);
void (^faviconHandler)(NSData*) = ^void(NSData* data) {
- base::scoped_nsobject<CRWWebUIManager> strongSelf([weakSelf retain]);
+ base::scoped_nsobject<CRWWebUIManager> strongSelf(weakSelf);
if (!strongSelf)
return;
NSString* base64EncodedResource = [data base64EncodedStringWithOptions:0];
« no previous file with comments | « ios/web/BUILD.gn ('k') | ios/web/webui/crw_web_ui_page_builder.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698