Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 2259993002: git cl patch: bail out quickly if there is no branch. (Closed)

Created:
4 years, 4 months ago by tandrii(chromium)
Modified:
4 years, 4 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, tandrii+omg_git_cl_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@fix-611020
Target Ref:
refs/heads/master
Visibility:
Public.

Description

git cl patch: bail out quickly if there is no branch. This is because later calls to SetIssue() would fail. R=michaelpg@chromium.org BUG=611020 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/df09a46d7cec6d4a523a0bb7d740d70b3ac7c663

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M git_cl.py View 1 chunk +2 lines, -0 lines 1 comment Download
M tests/git_cl_test.py View 4 chunks +9 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (6 generated)
tandrii(chromium)
4 years, 4 months ago (2016-08-18 20:58:16 UTC) #1
michaelpg
lgtm https://codereview.chromium.org/2259993002/diff/1/git_cl.py File git_cl.py (right): https://codereview.chromium.org/2259993002/diff/1/git_cl.py#newcode4410 git_cl.py:4410: DieWithError('A branch is required to apply patch. Hint: ...
4 years, 4 months ago (2016-08-18 23:03:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2259993002/1
4 years, 4 months ago (2016-08-18 23:21:02 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 23:23:59 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/df09a46d7cec6d...

Powered by Google App Engine
This is Rietveld 408576698