git_cl.py - Issue 2259993002: git cl patch: bail out quickly if there is no branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: git_cl.py

Issue 2259993002: git cl patch: bail out quickly if there is no branch. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@fix-611020

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: git_cl.py

diff --git a/git_cl.py b/git_cl.py

index 434cf45a48a10739d0ca1af231663fa7ca333f24..771c5c11bdd63e745dc02f4250b84b1306ab2d24 100755

--- a/git_cl.py

+++ b/git_cl.py

@@ -4406,6 +4406,8 @@ def CMDpatch(parser, args):

RunGit(['branch', '-D', options.newbranch],

stderr=subprocess2.PIPE, error_ok=True)

RunGit(['new-branch', options.newbranch])

+ elif not GetCurrentBranch():

+ DieWithError('A branch is required to apply patch. Hint: use -b option.')

michaelpg 2016/08/18 23:03:46 sweet, didn't know about that option

cl = Changelist(auth_config=auth_config, codereview=options.forced_codereview)

« no previous file with comments | « no previous file | tests/git_cl_test.py » ('j') | no next file with comments »