Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2259743003:
Disable top_10_mobile_memory test on reference build. (Closed)
|
Created:
4 years, 4 months ago by alexandermont Modified:
4 years, 4 months ago Reviewers:
eakuefner CC:
chromium-reviews, telemetry-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionDisable top_10_mobile_memory test on reference build.
This test is working on current build and so will pass ass soon
as the reference build is rolled.
BUG=chromium:639007
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
Committed: https://crrev.com/b77a137cf1723290b1286045d06b601f77e804be
Cr-Commit-Position: refs/heads/master@{#413650}
Patch Set 1 #Patch Set 2 : fix typo #Patch Set 3 : fix change in both sections #Messages
Total messages: 23 (10 generated)
Description was changed from ========== Disable top_10_mobile_memory test on reference build. This test is working on current build and so will pass ass soon as the reference build is rolled. BUG=chromium:639007 ========== to ========== Disable top_10_mobile_memory test on reference build. This test is working on current build and so will pass ass soon as the reference build is rolled. BUG=chromium:639007 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
alexandermont@chromium.org changed reviewers: + eakuefner@chromium.org
This is a little overzealous if it's only failing on the 5X. How about adding "and possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X'" to make it only disable on that device? Also, nit: can you please write "crbug.com/..." instead of just crbug? Not everyone has access to that short link, so we like to use .com.
Done
lgtm
The CQ bit was checked by alexandermont@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: winx64_10_perf_cq on master.tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_10_perf_c...)
The CQ bit was checked by alexandermont@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Exceeded global retry quota
The CQ bit was checked by alexandermont@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_retina_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by alexandermont@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Disable top_10_mobile_memory test on reference build. This test is working on current build and so will pass ass soon as the reference build is rolled. BUG=chromium:639007 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== Disable top_10_mobile_memory test on reference build. This test is working on current build and so will pass ass soon as the reference build is rolled. BUG=chromium:639007 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/b77a137cf1723290b1286045d06b601f77e804be Cr-Commit-Position: refs/heads/master@{#413650} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/b77a137cf1723290b1286045d06b601f77e804be Cr-Commit-Position: refs/heads/master@{#413650} |
