Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Side by Side Diff: tools/perf/benchmarks/v8.py

Issue 2259743003: Disable top_10_mobile_memory test on reference build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix change in both sections Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 import os 4 import os
5 import re 5 import re
6 6
7 from core import path_util 7 from core import path_util
8 from core import perf_benchmark 8 from core import perf_benchmark
9 from page_sets import google_pages 9 from page_sets import google_pages
10 10
(...skipping 234 matching lines...) Expand 10 before | Expand all | Expand 10 after
245 class V8MobileCodeSizeIgnition(_V8MemoryAndCodeSizeBenchmark): 245 class V8MobileCodeSizeIgnition(_V8MemoryAndCodeSizeBenchmark):
246 """Measures V8 heap and code size with ignition enabled on mobile web pages. 246 """Measures V8 heap and code size with ignition enabled on mobile web pages.
247 247
248 http://www.chromium.org/developers/design-documents/rendering-benchmarks 248 http://www.chromium.org/developers/design-documents/rendering-benchmarks
249 """ 249 """
250 250
251 def SetExtraBrowserOptions(self, options): 251 def SetExtraBrowserOptions(self, options):
252 super(V8MobileCodeSizeIgnition, self).SetExtraBrowserOptions(options) 252 super(V8MobileCodeSizeIgnition, self).SetExtraBrowserOptions(options)
253 v8_helper.EnableIgnition(options) 253 v8_helper.EnableIgnition(options)
254 254
255 # crbug.com/639007
256 @classmethod
257 def ShouldDisable(cls, possible_browser):
258 if (possible_browser.browser_type == 'reference' and
259 possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X'):
260 return True
261
255 @classmethod 262 @classmethod
256 def Name(cls): 263 def Name(cls):
257 return 'top_10_mobile_memory_ignition' 264 return 'top_10_mobile_memory_ignition'
258 265
259 266
260 @benchmark.Enabled('android') 267 @benchmark.Enabled('android')
261 class V8MobileCodeSize(_V8MemoryAndCodeSizeBenchmark): 268 class V8MobileCodeSize(_V8MemoryAndCodeSizeBenchmark):
262 """Measures V8 heap and code size on mobile web pages. 269 """Measures V8 heap and code size on mobile web pages.
263 270
264 http://www.chromium.org/developers/design-documents/rendering-benchmarks 271 http://www.chromium.org/developers/design-documents/rendering-benchmarks
265 """ 272 """
266 273
274 # crbug.com/639007
275 @classmethod
276 def ShouldDisable(cls, possible_browser):
277 if (possible_browser.browser_type == 'reference' and
278 possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X'):
279 return True
280
267 @classmethod 281 @classmethod
268 def Name(cls): 282 def Name(cls):
269 return 'top_10_mobile_memory' 283 return 'top_10_mobile_memory'
270 284
271 285
272 class V8Adword(perf_benchmark.PerfBenchmark): 286 class V8Adword(perf_benchmark.PerfBenchmark):
273 """Measures V8 Execution metrics on the Adword page.""" 287 """Measures V8 Execution metrics on the Adword page."""
274 288
275 options = {'pageset_repeat': 3} 289 options = {'pageset_repeat': 3}
276 290
(...skipping 22 matching lines...) Expand all
299 return True 313 return True
300 # http://crbug.com/623576 314 # http://crbug.com/623576
301 if (possible_browser.platform.GetDeviceTypeName() == 'Nexus 5' or 315 if (possible_browser.platform.GetDeviceTypeName() == 'Nexus 5' or
302 possible_browser.platform.GetDeviceTypeName() == 'Nexus 7'): 316 possible_browser.platform.GetDeviceTypeName() == 'Nexus 7'):
303 return True 317 return True
304 return False 318 return False
305 319
306 @classmethod 320 @classmethod
307 def ShouldTearDownStateAfterEachStoryRun(cls): 321 def ShouldTearDownStateAfterEachStoryRun(cls):
308 return True 322 return True
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698