Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: tools/perf/benchmarks/v8.py

Issue 2259743003: Disable top_10_mobile_memory test on reference build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix change in both sections Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/v8.py
diff --git a/tools/perf/benchmarks/v8.py b/tools/perf/benchmarks/v8.py
index a2780c3d5e76af563b271081eca49e16bc27466b..623ef9db5b24fd432267f8ee62cce37d6d614d3e 100644
--- a/tools/perf/benchmarks/v8.py
+++ b/tools/perf/benchmarks/v8.py
@@ -252,6 +252,13 @@ class V8MobileCodeSizeIgnition(_V8MemoryAndCodeSizeBenchmark):
super(V8MobileCodeSizeIgnition, self).SetExtraBrowserOptions(options)
v8_helper.EnableIgnition(options)
+ # crbug.com/639007
+ @classmethod
+ def ShouldDisable(cls, possible_browser):
+ if (possible_browser.browser_type == 'reference' and
+ possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X'):
+ return True
+
@classmethod
def Name(cls):
return 'top_10_mobile_memory_ignition'
@@ -264,6 +271,13 @@ class V8MobileCodeSize(_V8MemoryAndCodeSizeBenchmark):
http://www.chromium.org/developers/design-documents/rendering-benchmarks
"""
+ # crbug.com/639007
+ @classmethod
+ def ShouldDisable(cls, possible_browser):
+ if (possible_browser.browser_type == 'reference' and
+ possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X'):
+ return True
+
@classmethod
def Name(cls):
return 'top_10_mobile_memory'
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698