Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1526)

Unified Diff: appengine/findit/handlers/try_job_dashboard.py

Issue 2259513003: [Findit] Display last build bucket response to try job dashboard (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/handlers/try_job_dashboard.py
diff --git a/appengine/findit/handlers/try_job_dashboard.py b/appengine/findit/handlers/try_job_dashboard.py
index 56f1ea3a5e593d01a26be759ef6202049fffec9c..796f729184b10d4339af28f7724e006312acc607 100644
--- a/appengine/findit/handlers/try_job_dashboard.py
+++ b/appengine/findit/handlers/try_job_dashboard.py
@@ -4,6 +4,7 @@
from datetime import datetime
from datetime import time
from datetime import timedelta
+import json
from common.base_handler import BaseHandler
from common.base_handler import Permission
@@ -84,7 +85,9 @@ class TryJobDashboard(BaseHandler):
'pending_time': _FormatDuration(
try_job_data.request_time, try_job_data.start_time),
'request_time': _FormatDatetime(try_job_data.request_time),
- 'try_job_url': try_job_data.try_job_url
+ 'try_job_url': try_job_data.try_job_url,
+ 'last_buildbucket_response': json.dumps(
+ try_job_data.last_buildbucket_response, sort_keys=True)
chanli 2016/08/17 21:17:38 I'm not so sure about this, but what will happen i
stgao 2016/08/18 16:52:03 Could the conversion from json to string be handle
lijeffrey 2016/08/18 23:59:14 Unfortunately indent on the template side doesn't
}
if not try_job_data.end_time and not try_job_data.error:

Powered by Google App Engine
This is Rietveld 408576698