[Findit] Display last build bucket response to try job dashboard

appengine/findit/handlers/try_job_dashboard.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.

[chanli, 2016/08/17 21:17:38]

Nit: Add an empty line?

[lijeffrey, 2016/08/18 23:59:14]

Done.

 from datetime import datetime
 from datetime import time
 from datetime import timedelta
+import json
 
 from common.base_handler import BaseHandler
 from common.base_handler import Permission
 from model.wf_try_job_data import WfTryJobData
 
 
 NOT_AVAILABLE = 'N/A'
 
 
 # TODO(lijeffrey): Refactor formatting functions into a separate module that
@@ skipping 60 matching lines @@
 
     for try_job_data in try_job_data_list:
       try_job_display_data = {
           'master_name': try_job_data.master_name,
           'builder_name': try_job_data.builder_name,
           'build_number': try_job_data.build_number,
           'try_job_type': try_job_data.try_job_type,
           'pending_time': _FormatDuration(
               try_job_data.request_time, try_job_data.start_time),
           'request_time': _FormatDatetime(try_job_data.request_time),
-          'try_job_url': try_job_data.try_job_url
+          'try_job_url': try_job_data.try_job_url,
+          'last_buildbucket_response': json.dumps(
+              try_job_data.last_buildbucket_response, sort_keys=True)

[chanli, 2016/08/17 21:17:38]

I'm not so sure about this, but what will happen if you add indent here?

[stgao, 2016/08/18 16:52:03]

Could the conversion from json to string be handled in the html template itself?

[lijeffrey, 2016/08/18 23:59:14]

Unfortunately indent on the template side doesn't seem to do anything. It
appears the existence of a json inside the json here causes problems on the
other side, so instead I will write a function to preprocess the json here first
so it can be properly displayed.

       }
 
       if not try_job_data.end_time and not try_job_data.error:
         try_job_display_data['elapsed_time'] = (
             _FormatDuration(try_job_data.request_time, datetime.utcnow()) if
             try_job_data.request_time else None)
         try_job_display_data['status'] = (
             'running' if try_job_data.start_time else 'pending')
         try_jobs_in_progress.append(try_job_display_data)
       elif try_job_data.error:
@@ skipping 13 matching lines @@
         'end_date': _FormatDatetime(end_date),
         'try_jobs_in_progress': try_jobs_in_progress,
         'try_jobs_with_error': try_jobs_with_error,
         'successfully_completed_try_jobs': successfully_completed_try_jobs
     }
 
     return {
         'template': 'try_job_dashboard.html',
         'data': data
     }