Chromium Code Reviews Chromium Code Reviews
Issue 2259513003:
[Findit] Display last build bucket response to try job dashboard (Closed)
Base URL: https://chromium.googlesource.com/infra/infra.git@master| Index: appengine/findit/templates/try_job_dashboard.html |
| diff --git a/appengine/findit/templates/try_job_dashboard.html b/appengine/findit/templates/try_job_dashboard.html |
| index 7d30be65e6109a9f70966036ded4f78da7711b96..c63d672acee49515860e3aa976cd10a2dd424380 100644 |
| --- a/appengine/findit/templates/try_job_dashboard.html |
| +++ b/appengine/findit/templates/try_job_dashboard.html |
| @@ -3,7 +3,9 @@ |
| <title>Try Job Dashboard</title> |
| <meta charset="utf-8"> |
| <link rel="stylesheet" href="/common.css"> |
| + <link rel="stylesheet" href="https://ajax.googleapis.com/ajax/libs/jqueryui/1.11.1/themes/smoothness/jquery-ui.css"> |
| <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.11.1/jquery.min.js"></script> |
| + <script src="https://ajax.googleapis.com/ajax/libs/jqueryui/1.11.1/jquery-ui.min.js"></script> |
| <script> |
| function createUrl(parameters) { |
| var params = []; |
| @@ -30,8 +32,21 @@ |
| }; |
| $(document).ready(function() { |
| + $('#buildbucket-response-dialog').dialog({ |
| + autoOpen: false, |
| + modal: true, |
| + width: 1200, |
| + }); |
| + $('.show-response').each(function() { |
| + $(this).click(function() { |
| + var lastBuildbucketResponseText = $(this).attr('data-text'); |
| + $('#buildbucket-response-dialog').text(lastBuildbucketResponseText); |
|
stgao
2016/08/18 16:52:03
Now the text is a raw string, should we use JSON.s
lijeffrey
2016/08/18 23:59:14
Done.
|
| + $('#buildbucket-response-dialog').dialog('open'); |
| + }) |
| + }); |
| $('#submit').click(requestDataBetweenDateRange); |
| }); |
| + |
| </script> |
| </head> |
| <body> |
| @@ -57,6 +72,7 @@ |
| <th>Elapsed Time</th> |
| <th>Status</th> |
| <th>Try Job URL</th> |
| + <th>Last Buildbucket Response</th> |
| </tr> |
| <tbody> |
| {% for try_job_display_data in try_jobs_in_progress %} |
| @@ -81,6 +97,9 @@ |
| <a href="{{ try_job_display_data.try_job_url }}" target="_blank">link</a> |
| {% endif %} |
| </td> |
| + <td> |
| + <button class="show-response" id="in_progress_response_{{ loop.index }}" data-text="{{ try_job_display_data.last_buildbucket_response }}">show</button> |
| + </td> |
| </tr> |
| {% endfor %} |
| </tbody> |
| @@ -104,6 +123,7 @@ |
| <th>Execution Time</th> |
| <th>Error Message</th> |
| <th>Try Job URL</th> |
| + <th>Last Buildbucket Response</th> |
| </tr> |
| <tbody> |
| {% for try_job_display_data in try_jobs_with_error %} |
| @@ -128,6 +148,9 @@ |
| <a href="{{ try_job_display_data.try_job_url }}" target="_blank">link</a> |
| {% endif %} |
| </td> |
| + <td> |
| + <button class="show-response" id="error_response_{{ loop.index }}" data-text="{{ try_job_display_data.last_buildbucket_response }}">show</button> |
| + </td> |
| </tr> |
| {% endfor %} |
| </tbody> |
| @@ -151,6 +174,7 @@ |
| <th>Execution Time</th> |
| <th>Culprit Found</th> |
| <th>Try Job URL</th> |
| + <th>Last Buildbucket Response</th> |
| </tr> |
| <tbody> |
| {% for try_job_display_data in successfully_completed_try_jobs %} |
| @@ -175,6 +199,9 @@ |
| <a href="{{ try_job_display_data.try_job_url }}" target="_blank">link</a> |
| {% endif %} |
| </td> |
| + <td> |
| + <button class="show-response" id="completed_response_{{ loop.index }}" data-text="{{ try_job_display_data.last_buildbucket_response }}">show</button> |
|
chanli
2016/08/17 21:17:38
It seems the tables share most of the columns, so
lijeffrey
2016/08/18 23:59:14
That would require this entire file be rewritten,
|
| + </td> |
| </tr> |
| {% endfor %} |
| </tbody> |
| @@ -183,4 +210,5 @@ |
| No try-jobs have completed within the time range requested |
| {% endif %} |
| </div> |
| + <div id="buildbucket-response-dialog" title="Buildbucket response"></div> |
| </body> |
