Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 2259173002: Fix style errors in core/html/shadow/. (Closed)

Created:
4 years, 4 months ago by tkent
Modified:
4 years, 4 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix style errors in core/html/shadow/. Mainly ASSERT() -> DCHECK*(). This CL has no behavior changes. BUG=596760 Committed: https://crrev.com/d348310d0f641df4021694b95084707919ade5be Cr-Commit-Position: refs/heads/master@{#413083}

Patch Set 1 #

Total comments: 1

Messages

Total messages: 17 (12 generated)
tkent
yosin@, would you review this please?
4 years, 4 months ago (2016-08-19 06:46:08 UTC) #9
yosin_UTC9
lgtm https://codereview.chromium.org/2259173002/diff/20001/third_party/WebKit/Source/core/html/shadow/DateTimeEditElement.cpp File third_party/WebKit/Source/core/html/shadow/DateTimeEditElement.cpp (right): https://codereview.chromium.org/2259173002/diff/20001/third_party/WebKit/Source/core/html/shadow/DateTimeEditElement.cpp#newcode425 third_party/WebKit/Source/core/html/shadow/DateTimeEditElement.cpp:425: DCHECK(!msPerFieldUnitDecimal.isZero()); OPTIONAL: It seems we want to have ...
4 years, 4 months ago (2016-08-19 08:01:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2259173002/20001
4 years, 4 months ago (2016-08-19 08:02:13 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 4 months ago (2016-08-19 08:06:20 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 08:08:52 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d348310d0f641df4021694b95084707919ade5be
Cr-Commit-Position: refs/heads/master@{#413083}

Powered by Google App Engine
This is Rietveld 408576698