third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp - Issue 2259173002: Fix style errors in core/html/shadow/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp

Issue 2259173002: Fix style errors in core/html/shadow/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/shadow/DateTimeEditElement.cpp ('K') | « third_party/WebKit/Source/core/html/shadow/DateTimeEditElement.cpp ('k') | third_party/WebKit/Source/core/html/shadow/DateTimeFieldElements.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp

diff --git a/third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp b/third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp

index 49ed736f024506fd35942f71f60b3c02fc764116..dd47b86b89dd22839ead171481ad490c634381f9 100644

--- a/third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp

+++ b/third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp

@@ -220,7 +220,7 @@ void DateTimeFieldElement::updateVisibleValue(EventBehavior eventBehavior)

{

Text* const textNode = toText(firstChild());

const String newVisibleValue = visibleValue();

- ASSERT(newVisibleValue.length() > 0);

+ DCHECK_GT(newVisibleValue.length(), 0u);

if (textNode->wholeText() == newVisibleValue)

return;