Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: third_party/WebKit/Source/core/html/shadow/DateTimeSymbolicFieldElement.cpp

Issue 2259173002: Fix style errors in core/html/shadow/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/shadow/DateTimeSymbolicFieldElement.cpp
diff --git a/third_party/WebKit/Source/core/html/shadow/DateTimeSymbolicFieldElement.cpp b/third_party/WebKit/Source/core/html/shadow/DateTimeSymbolicFieldElement.cpp
index a37caaebec582ac57eacdc64ce22e315683068ed..5f89a45c07d90017cfaef99bddc30c97b85bad58 100644
--- a/third_party/WebKit/Source/core/html/shadow/DateTimeSymbolicFieldElement.cpp
+++ b/third_party/WebKit/Source/core/html/shadow/DateTimeSymbolicFieldElement.cpp
@@ -55,10 +55,10 @@ DateTimeSymbolicFieldElement::DateTimeSymbolicFieldElement(Document& document, F
, m_minimumIndex(minimum)
, m_maximumIndex(maximum)
{
- ASSERT(!symbols.isEmpty());
- ASSERT(m_minimumIndex >= 0);
- ASSERT_WITH_SECURITY_IMPLICATION(m_maximumIndex < static_cast<int>(m_symbols.size()));
- ASSERT(m_minimumIndex <= m_maximumIndex);
+ DCHECK(!symbols.isEmpty());
+ DCHECK_GE(m_minimumIndex, 0);
+ SECURITY_DCHECK(m_maximumIndex < static_cast<int>(m_symbols.size()));
+ DCHECK_LE(m_minimumIndex, m_maximumIndex);
}
float DateTimeSymbolicFieldElement::maximumWidth(const ComputedStyle& style)
@@ -118,8 +118,9 @@ void DateTimeSymbolicFieldElement::stepDown()
if (hasValue()) {
if (!indexIsInRange(--m_selectedIndex))
m_selectedIndex = m_maximumIndex;
- } else
+ } else {
m_selectedIndex = m_maximumIndex;
+ }
updateVisibleValue(DispatchEvent);
}
@@ -128,8 +129,9 @@ void DateTimeSymbolicFieldElement::stepUp()
if (hasValue()) {
if (!indexIsInRange(++m_selectedIndex))
m_selectedIndex = m_minimumIndex;
- } else
+ } else {
m_selectedIndex = m_minimumIndex;
+ }
updateVisibleValue(DispatchEvent);
}

Powered by Google App Engine
This is Rietveld 408576698