Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(20)

Issue 2258973002: Avoid LayoutFullScreen to be orthogonal writing-mode roots when reattached (Closed)

Created:
1 year, 3 months ago by kojii
Modified:
1 year, 3 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid LayoutFullScreen to be orthogonal writing-mode roots when reattached The previous CL to avoid LayoutFullScreen to be orthogonal writing-mode roots[1] copied the writing-mode when adding it to the parent. However, when reattach occurs, LayoutTreeBuilder creates LayoutFullScreen before the target is added to the parent, and thus LayoutFullScreen fails to copy from the parent. This patch copies the writing-mode when creating LayoutFullScreen. [1] http://crrev.com/1721653002 BUG=638571 Committed: https://crrev.com/119d9ebab5f2682ec5b3afe35ed078a80ae08635 Cr-Commit-Position: refs/heads/master@{#413089}

Patch Set 1 #

Patch Set 2 : Rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -5 lines) Patch
A third_party/WebKit/LayoutTests/fullscreen/orthogonal-writing-mode-full-screen-reattach-crash.html View 1 chunk +23 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fullscreen/orthogonal-writing-mode-full-screen-reattach-crash-expected.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFullScreen.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp View 3 chunks +8 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
kojii
PTAL.
1 year, 3 months ago (2016-08-19 01:18:17 UTC) #10
eae
Nice, LGTM
1 year, 3 months ago (2016-08-19 01:21:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2258973002/20001
1 year, 3 months ago (2016-08-19 03:15:01 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/276664)
1 year, 3 months ago (2016-08-19 05:38:40 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2258973002/20001
1 year, 3 months ago (2016-08-19 07:05:11 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
1 year, 3 months ago (2016-08-19 08:55:33 UTC) #19
commit-bot: I haz the power
1 year, 3 months ago (2016-08-19 08:57:37 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/119d9ebab5f2682ec5b3afe35ed078a80ae08635
Cr-Commit-Position: refs/heads/master@{#413089}

Powered by Google App Engine
This is Rietveld efc10ee0f