Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(981)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp

Issue 2258973002: Avoid LayoutFullScreen to be orthogonal writing-mode roots when reattached (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebaseline Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp b/third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp
index f17fb6a68560f7d0f397222ea2aa9f93939f0995..bbeb3993496a3096cd0052786e689ad9e9693679 100644
--- a/third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutFullScreen.cpp
@@ -92,7 +92,7 @@ void LayoutFullScreen::willBeDestroyed()
LayoutFlexibleBox::willBeDestroyed();
}
-void LayoutFullScreen::updateStyle()
+void LayoutFullScreen::updateStyle(LayoutObject* parent)
{
RefPtr<ComputedStyle> fullscreenStyle = ComputedStyle::create();
@@ -117,7 +117,12 @@ void LayoutFullScreen::updateStyle()
fullscreenStyle->setBackgroundColor(StyleColor(Color::black));
- setStyleWithWritingModeOfParent(fullscreenStyle);
+ setStyleWithWritingModeOf(fullscreenStyle, parent);
+}
+
+void LayoutFullScreen::updateStyle()
+{
+ updateStyle(parent());
}
LayoutObject* LayoutFullScreen::wrapLayoutObject(LayoutObject* object, LayoutObject* parent, Document* document)
@@ -127,7 +132,7 @@ LayoutObject* LayoutFullScreen::wrapLayoutObject(LayoutObject* object, LayoutObj
DeprecatedDisableModifyLayoutTreeStructureAsserts disabler;
LayoutFullScreen* fullscreenLayoutObject = LayoutFullScreen::createAnonymous(document);
- fullscreenLayoutObject->updateStyle();
+ fullscreenLayoutObject->updateStyle(parent);
if (parent && !parent->isChildAllowed(fullscreenLayoutObject, fullscreenLayoutObject->styleRef())) {
fullscreenLayoutObject->destroy();
return nullptr;
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutFullScreen.h ('k') | third_party/WebKit/Source/core/layout/LayoutObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698