Added static assert to BitField to ensure the contents fit within the field

Added static assert to BitField to ensure the contents fit within the field

Fixed ExtraICStateField which used 1 bits more than were available
BUG=

Committed: https://crrev.com/3cbb5e48068572a2c50017f6018fca09ad5a4e27
Cr-Commit-Position: refs/heads/master@{#38697}

[heimbuef, 2016-08-17 14:28:06]

heimbuef@google.com changed reviewers:
+ jkummerow@chromium.org

[heimbuef, 2016-08-17 14:28:06]

PTAL

[Jakob Kummerow, 2016-08-17 15:47:01]

lgtm

https://codereview.chromium.org/2258473002/diff/1/src/utils.h
File src/utils.h (right):

https://codereview.chromium.org/2258473002/diff/1/src/utils.h#newcode309
src/utils.h:309: STATIC_ASSERT((kNext - 1) / 8 < sizeof(U));
How about:

STATIC_ASSERT(kNext / kBitsPerByte <= sizeof(U));

[heimbuef, 2016-08-18 07:38:37]

The CQ bit was checked by heimbuef@google.com

[commit-bot: I haz the power, 2016-08-18 07:38:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[heimbuef, 2016-08-18 07:50:55]

On 2016/08/17 15:47:01, Jakob wrote:
> lgtm
> 
> https://codereview.chromium.org/2258473002/diff/1/src/utils.h
> File src/utils.h (right):
> 
> https://codereview.chromium.org/2258473002/diff/1/src/utils.h#newcode309
> src/utils.h:309: STATIC_ASSERT((kNext - 1) / 8 < sizeof(U));
> How about:
> 
> STATIC_ASSERT(kNext / kBitsPerByte <= sizeof(U));

kNext / kBitsPerByte <= sizeof(U) is not correct (try 33 with uint32_t for
example)

[commit-bot: I haz the power, 2016-08-18 08:05:44]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-08-18 08:06:06]

Description was changed from

==========
Added static assert to BitField to ensure the contents fit within the field

Fixed ExtraICStateField which used 1 bits more than were available
BUG=
==========

to

==========
Added static assert to BitField to ensure the contents fit within the field

Fixed ExtraICStateField which used 1 bits more than were available
BUG=

Committed: https://crrev.com/3cbb5e48068572a2c50017f6018fca09ad5a4e27
Cr-Commit-Position: refs/heads/master@{#38697}
==========

[commit-bot: I haz the power, 2016-08-18 08:06:06]

Patchset 1 (id:??) landed as
https://crrev.com/3cbb5e48068572a2c50017f6018fca09ad5a4e27
Cr-Commit-Position: refs/heads/master@{#38697}