src/utils.h - Issue 2258473002: Added static assert to BitField to ensure the contents fit within the field

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/utils.h

Issue 2258473002: Added static assert to BitField to ensure the contents fit within the field (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/utils.h

diff --git a/src/utils.h b/src/utils.h

index f95a136f96e6b0494057193d9f2da28e4faa8b86..a58439971f4c1f5ac291c7188a703a5b404946e3 100644

--- a/src/utils.h

+++ b/src/utils.h

@@ -305,8 +305,9 @@ class BitFieldBase {

static T decode(U value) {

return static_cast<T>((value & kMask) >> shift);

}

-};

+ STATIC_ASSERT((kNext - 1) / 8 < sizeof(U));

Jakob Kummerow 2016/08/17 15:47:01 How about: STATIC_ASSERT(kNext / kBitsPerByte <=

+};

template <class T, int shift, int size>

class BitField8 : public BitFieldBase<T, shift, size, uint8_t> {};

« no previous file with comments | « src/objects.h ('k') | no next file » | no next file with comments »