Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Unified Diff: src/objects.h

Issue 2258473002: Added static assert to BitField to ensure the contents fit within the field (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/utils.h » ('j') | src/utils.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index 1b0ded0aa82eaf2254a3742bc2d07aacefaf9f38..41e4f3439716a0338114d03449242f4505a95544 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -5469,9 +5469,10 @@ class Code: public HeapObject {
: public BitField<CacheHolderFlag, HasUnwindingInfoField::kNext, 2> {};
class KindField : public BitField<Kind, CacheHolderField::kNext, 5> {};
STATIC_ASSERT(NUMBER_OF_KINDS <= KindField::kMax);
- class ExtraICStateField : public BitField<ExtraICState, KindField::kNext,
- PlatformSmiTagging::kSmiValueSize -
- KindField::kNext + 1> {};
+ class ExtraICStateField
+ : public BitField<ExtraICState, KindField::kNext,
+ PlatformSmiTagging::kSmiValueSize - KindField::kNext> {
+ };
// KindSpecificFlags1 layout (STUB, BUILTIN and OPTIMIZED_FUNCTION)
static const int kStackSlotsFirstBit = 0;
« no previous file with comments | « no previous file | src/utils.h » ('j') | src/utils.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698