Issue 2258373002: [Findit] Move configurable parameters in try_job_util.py to config

Issue 2258373002: [Findit] Move configurable parameters in try_job_util.py to config (Closed)

Created:
4 years, 4 months ago by lijeffrey

Modified:
4 years, 4 months ago

Reviewers:
chanli, stgao

CC:
chromium-reviews, infra-reviews+infra_chromium.org, Sharu Jiang

Base URL:
https://chromium.googlesource.com/infra/infra.git@master

Target Ref:
refs/heads/master

Project:
infra

Visibility:
Public.

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -21 lines)			Patch
M	appengine/findit/handlers/config.py	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	appengine/findit/handlers/test/config_test.py	View	2 chunks	+11 lines, -6 lines	0 comments	Download
M	appengine/findit/waterfall/test/waterfall_config_test.py	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	appengine/findit/waterfall/test/wf_testcase.py	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	appengine/findit/waterfall/try_job_util.py	View	4 chunks	+11 lines, -12 lines	0 comments	Download

Total messages: 10 (4 generated)

lijeffrey

Note we eventually want to get rid of WfFailureGroup altogether, with the relevant information (blame ...

4 years, 4 months ago (2016-08-20 01:23:04 UTC) #1

chanli

On 2016/08/22 18:35:45, lijeffrey wrote: > actually adding reviewers this time :) ptal lgtm

4 years, 4 months ago (2016-08-22 18:42:15 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2258373002/1

4 years, 4 months ago (2016-08-22 19:02:01 UTC) #8

commit-bot: I haz the power

4 years, 4 months ago (2016-08-22 22:06:52 UTC) #10

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/1fb3937ec435e057aa87becf78d8f...