Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Unified Diff: appengine/findit/handlers/test/config_test.py

Issue 2258373002: [Findit] Move configurable parameters in try_job_util.py to config (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/handlers/config.py ('k') | appengine/findit/waterfall/test/waterfall_config_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/handlers/test/config_test.py
diff --git a/appengine/findit/handlers/test/config_test.py b/appengine/findit/handlers/test/config_test.py
index 55ac171b146cd5e9a9b22e009e6fcf27b48b9c75..2280eaa24f1b5fd7b6022804847c5533ee53b718 100644
--- a/appengine/findit/handlers/test/config_test.py
+++ b/appengine/findit/handlers/test/config_test.py
@@ -54,7 +54,8 @@ _MOCK_BUILDERS_TO_TRYBOTS = {
_MOCK_TRY_JOB_SETTINGS = {
'server_query_interval_seconds': 60,
'job_timeout_hours': 5,
- 'allowed_response_error_times': 1
+ 'allowed_response_error_times': 1,
+ 'max_seconds_look_back_for_group': 1
}
_MOCK_SWARMING_SETTINGS = {
@@ -462,24 +463,28 @@ class ConfigTest(testing.AppengineTestCase):
self.assertFalse(config._ValidateTryJobSettings({
'server_query_interval_seconds': '1', # Should be an int.
'job_timeout_hours': 1,
- 'allowed_response_error_times': 1
+ 'allowed_response_error_times': 1,
+ 'max_seconds_look_back_for_group': 1
}))
self.assertFalse(config._ValidateTryJobSettings({
'server_query_interval_seconds': 1,
'job_timeout_hours': '1', # Should be an int.
- 'allowed_response_error_times': 1
+ 'allowed_response_error_times': 1,
+ 'max_seconds_look_back_for_group': 1
}))
self.assertFalse(config._ValidateTryJobSettings({
'server_query_interval_seconds': 1,
'job_timeout_hours': 1,
'allowed_response_error_times': '1', # Should be an int.
+ 'max_seconds_look_back_for_group': 1
}))
- self.assertTrue(config._ValidateTryJobSettings({
+ self.assertFalse(config._ValidateTryJobSettings({
'server_query_interval_seconds': 1,
'job_timeout_hours': 1,
- 'allowed_response_error_times': 1
+ 'allowed_response_error_times': 1,
+ 'max_seconds_look_back_for_group': 'a' # Should be an int.
}))
- self.assertTrue(config._ValidateSwarmingSettings(_MOCK_SWARMING_SETTINGS))
+ self.assertTrue(config._ValidateTryJobSettings(_MOCK_TRY_JOB_SETTINGS))
def testValidateSwarmingSettings(self):
self.assertFalse(config._ValidateSwarmingSettings([]))
« no previous file with comments | « appengine/findit/handlers/config.py ('k') | appengine/findit/waterfall/test/waterfall_config_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698