[Findit] Move configurable parameters in try_job_util.py to config

appengine/findit/handlers/test/config_test.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import datetime
 import json
 import re
 import webapp2
 import webtest
 
@@ skipping 36 matching lines @@
         'builder1': {
             'mastername': 'tryserver1',
             'buildername': 'trybot1',
         }
     }
 }
 
 _MOCK_TRY_JOB_SETTINGS = {
     'server_query_interval_seconds': 60,
     'job_timeout_hours': 5,
-    'allowed_response_error_times': 1
+    'allowed_response_error_times': 1,
+    'max_seconds_look_back_for_group': 1
 }
 
 _MOCK_SWARMING_SETTINGS = {
     'server_host': 'chromium-swarm.appspot.com',
     'default_request_priority': 150,
     'request_expiration_hours': 20,
     'server_query_interval_seconds': 60,
     'task_timeout_hours': 23,
     'isolated_server': 'https://isolateserver.appspot.com',
     'isolated_storage_url': 'isolateserver.storage.googleapis.com',
@@ skipping 387 matching lines @@
     self.assertFalse(config._ValidateTrybotMapping({'a': ['b']}))
     self.assertFalse(config._ValidateTrybotMapping({'a': {'b': ['1']}}))
     self.assertFalse(config._ValidateTrybotMapping({'a': {'b': {}}}))
 
   def testValidateTryJobSettings(self):
     self.assertFalse(config._ValidateTryJobSettings([]))
     self.assertFalse(config._ValidateTryJobSettings({}))
     self.assertFalse(config._ValidateTryJobSettings({
         'server_query_interval_seconds': '1',  # Should be an int.
         'job_timeout_hours': 1,
-        'allowed_response_error_times': 1
+        'allowed_response_error_times': 1,
+        'max_seconds_look_back_for_group': 1
     }))
     self.assertFalse(config._ValidateTryJobSettings({
         'server_query_interval_seconds': 1,
         'job_timeout_hours': '1',  # Should be an int.
-        'allowed_response_error_times': 1
+        'allowed_response_error_times': 1,
+        'max_seconds_look_back_for_group': 1
     }))
     self.assertFalse(config._ValidateTryJobSettings({
         'server_query_interval_seconds': 1,
         'job_timeout_hours': 1,
         'allowed_response_error_times': '1',  # Should be an int.
+        'max_seconds_look_back_for_group': 1
     }))
-    self.assertTrue(config._ValidateTryJobSettings({
+    self.assertFalse(config._ValidateTryJobSettings({
         'server_query_interval_seconds': 1,
         'job_timeout_hours': 1,
-        'allowed_response_error_times': 1
+        'allowed_response_error_times': 1,
+        'max_seconds_look_back_for_group': 'a'  # Should be an int.
     }))
-    self.assertTrue(config._ValidateSwarmingSettings(_MOCK_SWARMING_SETTINGS))
+    self.assertTrue(config._ValidateTryJobSettings(_MOCK_TRY_JOB_SETTINGS))
 
   def testValidateSwarmingSettings(self):
     self.assertFalse(config._ValidateSwarmingSettings([]))
     self.assertFalse(config._ValidateSwarmingSettings({}))
     self.assertFalse(config._ValidateSwarmingSettings({
         'server_host': ['chromium-swarm.appspot.com'],  # Should be a string.
         'default_request_priority': 150,
         'request_expiration_hours': 20,
         'server_query_interval_seconds': 60,
         'task_timeout_hours': 23,
@@ skipping 197 matching lines @@
 
     self.assertEquals(expected_response, response.json_body)
 
   def testValidateActionSettings(self):
     self.assertFalse(config._ValidateActionSettings({}))
     self.assertTrue(config._ValidateActionSettings(
         {
             'cr_notification_build_threshold': 2,
             'cr_notification_latency_limit_minutes': 1000,
         }))