Reland of Remove content::NotificationPermissionDispatcher.

Reland of move content::NotificationPermissionDispatcher. (patchset #1 id:1 of https://codereview.chromium.org/2258673002/ )

Reason for revert:
Fixed the leak by adding a connection error handler that resets m_permissionService, breaking the circular reference between NotificationManager and pending Mojo callbacks.

Original issue's description:
> Revert of Remove content::NotificationPermissionDispatcher. (patchset #5 id:80001 of https://codereview.chromium.org/2244913002/ )
>
> Reason for revert:
> Causing failure on Builder WebKit Linux Leak
>
> https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/22036
>
> request-permission-detached-context.html
>
> 15:25:46.371 7635 worker/0 http/tests/notifications/request-permission-detached-context.html leaked
> 15:25:46.371 7635   Xlib:  extension "RANDR" missing on display ":9".
> 15:25:46.371 7635   Xlib:  extension "RANDR" missing on display ":9".
> 15:25:46.374 17565 [4/95] http/tests/notifications/request-permission-detached-context.html failed unexpectedly (leak detected: ({"numberOfLiveActiveDOMObjects":[2,6],"numberOfLiveDocuments":[1,3],"numberOfLiveNodes":[4,36],"numberOfLiveResources":[0,3]}))
> 15:25:46.372 7635 worker/0 http/tests/notifications/request-permission-detached-context.html failed:
> 15:25:46.372 7635 worker/0  leak detected: ({"numberOfLiveActiveDOMObjects":[2,6],"numberOfLiveDocuments":[1,3],"numberOfLiveNodes":[4,36],"numberOfLiveResources":[0,3]})
>
> Original issue's description:
> > Remove content::NotificationPermissionDispatcher.
> >
> > blink::Notification can make calls to the Mojo PermissionService itself.
> >
> > BUG=561879
> >
> > Committed: https://crrev.com/be876eec511985fc0f476628b7b43dc951bd04c5
> > Cr-Commit-Position: refs/heads/master@{#412636}
>
> TBR=esprehn@chromium.org,haraken@chromium.org,johnme@chromium.org,mvanouwerkerk@chromium.org,peter@chromium.org,reillyg@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=561879
>
> Committed: https://crrev.com/5241216894d534ab30c763375a78ad68e0d155db
> Cr-Commit-Position: refs/heads/master@{#412678}

# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=561879
Committed: https://crrev.com/a4fd553733bc0a7f6e0e110c66b0008c6dbf5a41
Cr-Commit-Position: refs/heads/master@{#414820}

[Reilly Grant (use Gerrit), 2016-08-20 00:27:51]

Created Reland of move content::NotificationPermissionDispatcher.

[Reilly Grant (use Gerrit), 2016-08-20 00:29:04]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-20 00:29:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Reilly Grant (use Gerrit), 2016-08-20 00:31:19]

Please take a look. The cause of the leak was that when a Mojo call is made on a
closed message pipe the result callback is never called. Since the result
callback holds persistent references to the NotificationManager object this
object cannot be GCed, causing a leak. The solution is to add a connection error
handler that explicitly closes the renderer side of the Mojo pipe, deleting all
the callbacks for outstanding calls.

[Reilly Grant (use Gerrit), 2016-08-20 00:33:22]

Description was changed from

==========
Reland of move content::NotificationPermissionDispatcher. (patchset #1 id:1 of
https://codereview.chromium.org/2258673002/ )

Reason for revert:
Fixed leak.

Original issue's description:
> Revert of Remove content::NotificationPermissionDispatcher. (patchset #5
id:80001 of https://codereview.chromium.org/2244913002/ )
> 
> Reason for revert:
> Causing failure on Builder WebKit Linux Leak
> 
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/b...
> 
> request-permission-detached-context.html
> 
> 15:25:46.371 7635 worker/0
http/tests/notifications/request-permission-detached-context.html leaked
> 15:25:46.371 7635   Xlib:  extension "RANDR" missing on display ":9".
> 15:25:46.371 7635   Xlib:  extension "RANDR" missing on display ":9".
> 15:25:46.374 17565 [4/95]
http/tests/notifications/request-permission-detached-context.html failed
unexpectedly (leak detected:
({"numberOfLiveActiveDOMObjects":[2,6],"numberOfLiveDocuments":[1,3],"numberOfLiveNodes":[4,36],"numberOfLiveResources":[0,3]}))
> 15:25:46.372 7635 worker/0
http/tests/notifications/request-permission-detached-context.html failed:
> 15:25:46.372 7635 worker/0  leak detected:
({"numberOfLiveActiveDOMObjects":[2,6],"numberOfLiveDocuments":[1,3],"numberOfLiveNodes":[4,36],"numberOfLiveResources":[0,3]})
> 
> Original issue's description:
> > Remove content::NotificationPermissionDispatcher.
> >
> > blink::Notification can make calls to the Mojo PermissionService itself.
> >
> > BUG=561879
> >
> > Committed: https://crrev.com/be876eec511985fc0f476628b7b43dc951bd04c5
> > Cr-Commit-Position: refs/heads/master@{#412636}
> 
>
TBR=esprehn@chromium.org,haraken@chromium.org,johnme@chromium.org,mvanouwerke...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=561879
> 
> Committed: https://crrev.com/5241216894d534ab30c763375a78ad68e0d155db
> Cr-Commit-Position: refs/heads/master@{#412678}

TBR=esprehn@chromium.org,haraken@chromium.org,johnme@chromium.org,mvanouwerke...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=561879
==========

to

==========
Reland of move content::NotificationPermissionDispatcher. (patchset #1 id:1 of
https://codereview.chromium.org/2258673002/ )

Reason for revert:
Fixed leak.

Original issue's description:
> Revert of Remove content::NotificationPermissionDispatcher. (patchset #5
id:80001 of https://codereview.chromium.org/2244913002/ )
> 
> Reason for revert:
> Causing failure on Builder WebKit Linux Leak
> 
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/b...
> 
> request-permission-detached-context.html
> 
> 15:25:46.371 7635 worker/0
http/tests/notifications/request-permission-detached-context.html leaked
> 15:25:46.371 7635   Xlib:  extension "RANDR" missing on display ":9".
> 15:25:46.371 7635   Xlib:  extension "RANDR" missing on display ":9".
> 15:25:46.374 17565 [4/95]
http/tests/notifications/request-permission-detached-context.html failed
unexpectedly (leak detected:
({"numberOfLiveActiveDOMObjects":[2,6],"numberOfLiveDocuments":[1,3],"numberOfLiveNodes":[4,36],"numberOfLiveResources":[0,3]}))
> 15:25:46.372 7635 worker/0
http/tests/notifications/request-permission-detached-context.html failed:
> 15:25:46.372 7635 worker/0  leak detected:
({"numberOfLiveActiveDOMObjects":[2,6],"numberOfLiveDocuments":[1,3],"numberOfLiveNodes":[4,36],"numberOfLiveResources":[0,3]})
> 
> Original issue's description:
> > Remove content::NotificationPermissionDispatcher.
> >
> > blink::Notification can make calls to the Mojo PermissionService itself.
> >
> > BUG=561879
> >
> > Committed: https://crrev.com/be876eec511985fc0f476628b7b43dc951bd04c5
> > Cr-Commit-Position: refs/heads/master@{#412636}
> 
>
TBR=esprehn@chromium.org,haraken@chromium.org,johnme@chromium.org,mvanouwerke...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=561879
> 
> Committed: https://crrev.com/5241216894d534ab30c763375a78ad68e0d155db
> Cr-Commit-Position: refs/heads/master@{#412678}

# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=561879
==========

[haraken, 2016-08-20 01:34:38]

LGTM

https://codereview.chromium.org/2258353002/diff/270001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/notifications/NotificationManager.cpp
(right):

https://codereview.chromium.org/2258353002/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/notifications/NotificationManager.cpp:100:
m_permissionService.reset();

Don't we need to reset m_notificationService as well?

[commit-bot: I haz the power, 2016-08-20 02:47:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 02:47:35]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[johnme, 2016-08-22 14:52:52]

notification bits lgtm, deferring to haraken for mojo lifetimes

[Peter Beverloo, 2016-08-22 14:54:46]

rs lgtm

https://codereview.chromium.org/2258353002/diff/270001/content/renderer/notif...
File content/renderer/notification_permission_dispatcher.h (left):

https://codereview.chromium.org/2258353002/diff/270001/content/renderer/notif...
content/renderer/notification_permission_dispatcher.h:1: // Copyright 2014 The
Chromium Authors. All rights reserved.
Please remove the per-file rules from content/renderer/OWNERS.

[Reilly Grant (use Gerrit), 2016-08-22 18:17:19]

Rebased and removed per-file rules from content/renderer/OWNERS.

[Reilly Grant (use Gerrit), 2016-08-22 18:17:33]

https://codereview.chromium.org/2258353002/diff/270001/content/renderer/notif...
File content/renderer/notification_permission_dispatcher.h (left):

https://codereview.chromium.org/2258353002/diff/270001/content/renderer/notif...
content/renderer/notification_permission_dispatcher.h:1: // Copyright 2014 The
Chromium Authors. All rights reserved.
On 2016/08/22 at 14:54:46, Peter Beverloo wrote:
> Please remove the per-file rules from content/renderer/OWNERS.

Done.

https://codereview.chromium.org/2258353002/diff/270001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/notifications/NotificationManager.cpp
(right):

https://codereview.chromium.org/2258353002/diff/270001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/notifications/NotificationManager.cpp:100:
m_permissionService.reset();
On 2016/08/20 at 01:34:38, haraken wrote:
> Don't we need to reset m_notificationService as well?

It doesn't matter for m_notificationService because the call made in
permissionStatus() is synchronous and so there isn't the possibility of an
outstanding callback during renderer shutdown.

[Reilly Grant (use Gerrit), 2016-08-22 18:17:44]

The CQ bit was checked by reillyg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 18:33:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 22:39:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 22:39:13]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Reilly Grant (use Gerrit), 2016-08-23 20:02:22]

esprehn@ can you take a quick look at this. The only thing changed from the
original patch is the connection error handler in NotificationManager.cpp.

[Reilly Grant (use Gerrit), 2016-08-26 17:00:06]

Ping.

[esprehn, 2016-08-26 17:09:50]

On 2016/08/26 at 17:00:06, reillyg wrote:
> Ping.

Can you update the description to explain how you fixed the leak?

[Reilly Grant (use Gerrit), 2016-08-26 17:13:15]

Description was changed from

==========
Reland of move content::NotificationPermissionDispatcher. (patchset #1 id:1 of
https://codereview.chromium.org/2258673002/ )

Reason for revert:
Fixed leak.

Original issue's description:
> Revert of Remove content::NotificationPermissionDispatcher. (patchset #5
id:80001 of https://codereview.chromium.org/2244913002/ )
> 
> Reason for revert:
> Causing failure on Builder WebKit Linux Leak
> 
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/b...
> 
> request-permission-detached-context.html
> 
> 15:25:46.371 7635 worker/0
http/tests/notifications/request-permission-detached-context.html leaked
> 15:25:46.371 7635   Xlib:  extension "RANDR" missing on display ":9".
> 15:25:46.371 7635   Xlib:  extension "RANDR" missing on display ":9".
> 15:25:46.374 17565 [4/95]
http/tests/notifications/request-permission-detached-context.html failed
unexpectedly (leak detected:
({"numberOfLiveActiveDOMObjects":[2,6],"numberOfLiveDocuments":[1,3],"numberOfLiveNodes":[4,36],"numberOfLiveResources":[0,3]}))
> 15:25:46.372 7635 worker/0
http/tests/notifications/request-permission-detached-context.html failed:
> 15:25:46.372 7635 worker/0  leak detected:
({"numberOfLiveActiveDOMObjects":[2,6],"numberOfLiveDocuments":[1,3],"numberOfLiveNodes":[4,36],"numberOfLiveResources":[0,3]})
> 
> Original issue's description:
> > Remove content::NotificationPermissionDispatcher.
> >
> > blink::Notification can make calls to the Mojo PermissionService itself.
> >
> > BUG=561879
> >
> > Committed: https://crrev.com/be876eec511985fc0f476628b7b43dc951bd04c5
> > Cr-Commit-Position: refs/heads/master@{#412636}
> 
>
TBR=esprehn@chromium.org,haraken@chromium.org,johnme@chromium.org,mvanouwerke...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=561879
> 
> Committed: https://crrev.com/5241216894d534ab30c763375a78ad68e0d155db
> Cr-Commit-Position: refs/heads/master@{#412678}

# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=561879
==========

to

==========
Reland of move content::NotificationPermissionDispatcher. (patchset #1 id:1 of
https://codereview.chromium.org/2258673002/ )

Reason for revert:
Fixed leak by adding a connection error handler that resets m_permissionService,
breaking the circular reference between NotificationManager and pending Mojo
callbacks.

Original issue's description:
> Revert of Remove content::NotificationPermissionDispatcher. (patchset #5
id:80001 of https://codereview.chromium.org/2244913002/ )
> 
> Reason for revert:
> Causing failure on Builder WebKit Linux Leak
> 
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/b...
> 
> request-permission-detached-context.html
> 
> 15:25:46.371 7635 worker/0
http/tests/notifications/request-permission-detached-context.html leaked
> 15:25:46.371 7635   Xlib:  extension "RANDR" missing on display ":9".
> 15:25:46.371 7635   Xlib:  extension "RANDR" missing on display ":9".
> 15:25:46.374 17565 [4/95]
http/tests/notifications/request-permission-detached-context.html failed
unexpectedly (leak detected:
({"numberOfLiveActiveDOMObjects":[2,6],"numberOfLiveDocuments":[1,3],"numberOfLiveNodes":[4,36],"numberOfLiveResources":[0,3]}))
> 15:25:46.372 7635 worker/0
http/tests/notifications/request-permission-detached-context.html failed:
> 15:25:46.372 7635 worker/0  leak detected:
({"numberOfLiveActiveDOMObjects":[2,6],"numberOfLiveDocuments":[1,3],"numberOfLiveNodes":[4,36],"numberOfLiveResources":[0,3]})
> 
> Original issue's description:
> > Remove content::NotificationPermissionDispatcher.
> >
> > blink::Notification can make calls to the Mojo PermissionService itself.
> >
> > BUG=561879
> >
> > Committed: https://crrev.com/be876eec511985fc0f476628b7b43dc951bd04c5
> > Cr-Commit-Position: refs/heads/master@{#412636}
> 
>
TBR=esprehn@chromium.org,haraken@chromium.org,johnme@chromium.org,mvanouwerke...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=561879
> 
> Committed: https://crrev.com/5241216894d534ab30c763375a78ad68e0d155db
> Cr-Commit-Position: refs/heads/master@{#412678}

# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=561879
==========

[Reilly Grant (use Gerrit), 2016-08-26 17:13:46]

Description was changed from

==========
Reland of move content::NotificationPermissionDispatcher. (patchset #1 id:1 of
https://codereview.chromium.org/2258673002/ )

Reason for revert:
Fixed leak by adding a connection error handler that resets m_permissionService,
breaking the circular reference between NotificationManager and pending Mojo
callbacks.

Original issue's description:
> Revert of Remove content::NotificationPermissionDispatcher. (patchset #5
id:80001 of https://codereview.chromium.org/2244913002/ )
> 
> Reason for revert:
> Causing failure on Builder WebKit Linux Leak
> 
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/b...
> 
> request-permission-detached-context.html
> 
> 15:25:46.371 7635 worker/0
http/tests/notifications/request-permission-detached-context.html leaked
> 15:25:46.371 7635   Xlib:  extension "RANDR" missing on display ":9".
> 15:25:46.371 7635   Xlib:  extension "RANDR" missing on display ":9".
> 15:25:46.374 17565 [4/95]
http/tests/notifications/request-permission-detached-context.html failed
unexpectedly (leak detected:
({"numberOfLiveActiveDOMObjects":[2,6],"numberOfLiveDocuments":[1,3],"numberOfLiveNodes":[4,36],"numberOfLiveResources":[0,3]}))
> 15:25:46.372 7635 worker/0
http/tests/notifications/request-permission-detached-context.html failed:
> 15:25:46.372 7635 worker/0  leak detected:
({"numberOfLiveActiveDOMObjects":[2,6],"numberOfLiveDocuments":[1,3],"numberOfLiveNodes":[4,36],"numberOfLiveResources":[0,3]})
> 
> Original issue's description:
> > Remove content::NotificationPermissionDispatcher.
> >
> > blink::Notification can make calls to the Mojo PermissionService itself.
> >
> > BUG=561879
> >
> > Committed: https://crrev.com/be876eec511985fc0f476628b7b43dc951bd04c5
> > Cr-Commit-Position: refs/heads/master@{#412636}
> 
>
TBR=esprehn@chromium.org,haraken@chromium.org,johnme@chromium.org,mvanouwerke...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=561879
> 
> Committed: https://crrev.com/5241216894d534ab30c763375a78ad68e0d155db
> Cr-Commit-Position: refs/heads/master@{#412678}

# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=561879
==========

to

==========
Reland of move content::NotificationPermissionDispatcher. (patchset #1 id:1 of
https://codereview.chromium.org/2258673002/ )

Reason for revert:
Fixed the leak by adding a connection error handler that resets
m_permissionService, breaking the circular reference between NotificationManager
and pending Mojo callbacks.

Original issue's description:
> Revert of Remove content::NotificationPermissionDispatcher. (patchset #5
id:80001 of https://codereview.chromium.org/2244913002/ )
> 
> Reason for revert:
> Causing failure on Builder WebKit Linux Leak
> 
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/b...
> 
> request-permission-detached-context.html
> 
> 15:25:46.371 7635 worker/0
http/tests/notifications/request-permission-detached-context.html leaked
> 15:25:46.371 7635   Xlib:  extension "RANDR" missing on display ":9".
> 15:25:46.371 7635   Xlib:  extension "RANDR" missing on display ":9".
> 15:25:46.374 17565 [4/95]
http/tests/notifications/request-permission-detached-context.html failed
unexpectedly (leak detected:
({"numberOfLiveActiveDOMObjects":[2,6],"numberOfLiveDocuments":[1,3],"numberOfLiveNodes":[4,36],"numberOfLiveResources":[0,3]}))
> 15:25:46.372 7635 worker/0
http/tests/notifications/request-permission-detached-context.html failed:
> 15:25:46.372 7635 worker/0  leak detected:
({"numberOfLiveActiveDOMObjects":[2,6],"numberOfLiveDocuments":[1,3],"numberOfLiveNodes":[4,36],"numberOfLiveResources":[0,3]})
> 
> Original issue's description:
> > Remove content::NotificationPermissionDispatcher.
> >
> > blink::Notification can make calls to the Mojo PermissionService itself.
> >
> > BUG=561879
> >
> > Committed: https://crrev.com/be876eec511985fc0f476628b7b43dc951bd04c5
> > Cr-Commit-Position: refs/heads/master@{#412636}
> 
>
TBR=esprehn@chromium.org,haraken@chromium.org,johnme@chromium.org,mvanouwerke...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=561879
> 
> Committed: https://crrev.com/5241216894d534ab30c763375a78ad68e0d155db
> Cr-Commit-Position: refs/heads/master@{#412678}

# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=561879
==========

[Reilly Grant (use Gerrit), 2016-08-26 17:13:53]

On 2016/08/26 at 17:09:50, esprehn wrote:
> On 2016/08/26 at 17:00:06, reillyg wrote:
> > Ping.
> 
> Can you update the description to explain how you fixed the leak?

Done.

[esprehn, 2016-08-26 17:32:07]

lgtm

[esprehn, 2016-08-26 17:33:00]

On 2016/08/26 at 17:32:07, esprehn wrote:
> lgtm

In the future you don't need this complicated nested change description. You can
just use the description of the original pre revert change and just mention that
it was reverted and what you fixed.

[Reilly Grant (use Gerrit), 2016-08-26 18:14:18]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2016-08-26 18:14:19]

The patchset sent to the CQ was uploaded after l-g-t-m from johnme@chromium.org,
peter@chromium.org, haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2258353002/#ps290001
(title: "Rebased and removed per-file rules from content/renderer/OWNERS.")

[Reilly Grant (use Gerrit), 2016-08-26 18:14:36]

On 2016/08/26 at 17:33:00, esprehn wrote:
> On 2016/08/26 at 17:32:07, esprehn wrote:
> > lgtm
> 
> In the future you don't need this complicated nested change description. You
can just use the description of the original pre revert change and just mention
that it was reverted and what you fixed.

Thanks.

[commit-bot: I haz the power, 2016-08-26 18:15:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 18:19:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-26 18:19:05]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Reilly Grant (use Gerrit), 2016-08-26 20:13:11]

The CQ bit was checked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2016-08-26 20:13:12]

The patchset sent to the CQ was uploaded after l-g-t-m from johnme@chromium.org,
peter@chromium.org, esprehn@chromium.org, haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2258353002/#ps310001
(title: "Remove NotificationPermissionClient initialization from
ChromeClientImpl.")

[commit-bot: I haz the power, 2016-08-26 20:14:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 21:44:03]

Committed patchset #4 (id:310001)

[commit-bot: I haz the power, 2016-08-26 21:46:03]

Description was changed from

==========
Reland of move content::NotificationPermissionDispatcher. (patchset #1 id:1 of
https://codereview.chromium.org/2258673002/ )

Reason for revert:
Fixed the leak by adding a connection error handler that resets
m_permissionService, breaking the circular reference between NotificationManager
and pending Mojo callbacks.

Original issue's description:
> Revert of Remove content::NotificationPermissionDispatcher. (patchset #5
id:80001 of https://codereview.chromium.org/2244913002/ )
> 
> Reason for revert:
> Causing failure on Builder WebKit Linux Leak
> 
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/b...
> 
> request-permission-detached-context.html
> 
> 15:25:46.371 7635 worker/0
http/tests/notifications/request-permission-detached-context.html leaked
> 15:25:46.371 7635   Xlib:  extension "RANDR" missing on display ":9".
> 15:25:46.371 7635   Xlib:  extension "RANDR" missing on display ":9".
> 15:25:46.374 17565 [4/95]
http/tests/notifications/request-permission-detached-context.html failed
unexpectedly (leak detected:
({"numberOfLiveActiveDOMObjects":[2,6],"numberOfLiveDocuments":[1,3],"numberOfLiveNodes":[4,36],"numberOfLiveResources":[0,3]}))
> 15:25:46.372 7635 worker/0
http/tests/notifications/request-permission-detached-context.html failed:
> 15:25:46.372 7635 worker/0  leak detected:
({"numberOfLiveActiveDOMObjects":[2,6],"numberOfLiveDocuments":[1,3],"numberOfLiveNodes":[4,36],"numberOfLiveResources":[0,3]})
> 
> Original issue's description:
> > Remove content::NotificationPermissionDispatcher.
> >
> > blink::Notification can make calls to the Mojo PermissionService itself.
> >
> > BUG=561879
> >
> > Committed: https://crrev.com/be876eec511985fc0f476628b7b43dc951bd04c5
> > Cr-Commit-Position: refs/heads/master@{#412636}
> 
>
TBR=esprehn@chromium.org,haraken@chromium.org,johnme@chromium.org,mvanouwerke...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=561879
> 
> Committed: https://crrev.com/5241216894d534ab30c763375a78ad68e0d155db
> Cr-Commit-Position: refs/heads/master@{#412678}

# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=561879
==========

to

==========
Reland of move content::NotificationPermissionDispatcher. (patchset #1 id:1 of
https://codereview.chromium.org/2258673002/ )

Reason for revert:
Fixed the leak by adding a connection error handler that resets
m_permissionService, breaking the circular reference between NotificationManager
and pending Mojo callbacks.

Original issue's description:
> Revert of Remove content::NotificationPermissionDispatcher. (patchset #5
id:80001 of https://codereview.chromium.org/2244913002/ )
>
> Reason for revert:
> Causing failure on Builder WebKit Linux Leak
>
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/b...
>
> request-permission-detached-context.html
>
> 15:25:46.371 7635 worker/0
http/tests/notifications/request-permission-detached-context.html leaked
> 15:25:46.371 7635   Xlib:  extension "RANDR" missing on display ":9".
> 15:25:46.371 7635   Xlib:  extension "RANDR" missing on display ":9".
> 15:25:46.374 17565 [4/95]
http/tests/notifications/request-permission-detached-context.html failed
unexpectedly (leak detected:
({"numberOfLiveActiveDOMObjects":[2,6],"numberOfLiveDocuments":[1,3],"numberOfLiveNodes":[4,36],"numberOfLiveResources":[0,3]}))
> 15:25:46.372 7635 worker/0
http/tests/notifications/request-permission-detached-context.html failed:
> 15:25:46.372 7635 worker/0  leak detected:
({"numberOfLiveActiveDOMObjects":[2,6],"numberOfLiveDocuments":[1,3],"numberOfLiveNodes":[4,36],"numberOfLiveResources":[0,3]})
>
> Original issue's description:
> > Remove content::NotificationPermissionDispatcher.
> >
> > blink::Notification can make calls to the Mojo PermissionService itself.
> >
> > BUG=561879
> >
> > Committed: https://crrev.com/be876eec511985fc0f476628b7b43dc951bd04c5
> > Cr-Commit-Position: refs/heads/master@{#412636}
>
>
TBR=esprehn@chromium.org,haraken@chromium.org,johnme@chromium.org,mvanouwerke...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=561879
>
> Committed: https://crrev.com/5241216894d534ab30c763375a78ad68e0d155db
> Cr-Commit-Position: refs/heads/master@{#412678}

# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=561879

Committed: https://crrev.com/a4fd553733bc0a7f6e0e110c66b0008c6dbf5a41
Cr-Commit-Position: refs/heads/master@{#414820}
==========

[commit-bot: I haz the power, 2016-08-26 21:46:05]

Patchset 4 (id:??) landed as
https://crrev.com/a4fd553733bc0a7f6e0e110c66b0008c6dbf5a41
Cr-Commit-Position: refs/heads/master@{#414820}