third_party/WebKit/public/web/WebFrameClient.h - Issue 2258353002: Reland of Remove content::NotificationPermissionDispatcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/web/WebFrameClient.h

Issue 2258353002: Reland of Remove content::NotificationPermissionDispatcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permissions_typemaps

Patch Set: Remove NotificationPermissionClient initialization from ChromeClientImpl. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/public/web/WebFrameClient.h

diff --git a/third_party/WebKit/public/web/WebFrameClient.h b/third_party/WebKit/public/web/WebFrameClient.h

index bc6314859ce7219f13cd1f6e9371f2a55a510c40..523b2d733fe7295b2fdcb2ff99cf42d49707e68c 100644

--- a/third_party/WebKit/public/web/WebFrameClient.h

+++ b/third_party/WebKit/public/web/WebFrameClient.h

@@ -89,7 +89,6 @@ class WebMediaPlayerEncryptedMediaClient;

class WebMediaPlayerSource;

class WebMediaSession;

class WebMediaStream;

-class WebNotificationPermissionCallback;

class WebServiceWorkerProvider;

class WebSocketHandle;

class WebPlugin;

@@ -371,11 +370,6 @@ public:

// Returns the effective connection type when the frame was fetched.

virtual WebEffectiveConnectionType getEffectiveConnectionType() { return WebEffectiveConnectionType::TypeUnknown; }

- // Web Notifications ---------------------------------------------------

- // Requests permission to display platform notifications on the origin of this frame.

- virtual void requestNotificationPermission(const WebSecurityOrigin&, WebNotificationPermissionCallback* callback) { }

// Push API ---------------------------------------------------

« no previous file with comments | « third_party/WebKit/public/blink_headers.gypi ('k') | third_party/WebKit/public/web/modules/notifications/OWNERS » ('j') | no next file with comments »