third_party/WebKit/Source/web/ChromeClientImpl.cpp - Issue 2258353002: Reland of Remove content::NotificationPermissionDispatcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2258353002: Reland of Remove content::NotificationPermissionDispatcher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permissions_typemaps

Patch Set: Remove NotificationPermissionClient initialization from ChromeClientImpl. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/notifications/NotificationPermissionClient.cpp ('k') | third_party/WebKit/Source/web/NotificationPermissionClientImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/ChromeClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/ChromeClientImpl.cpp b/third_party/WebKit/Source/web/ChromeClientImpl.cpp

index f274fb4f6962e807ca2ccf2a3604237a8e378785..c8625a81c818c6900c53bd9e13dd7e66ae9c03c3 100644

--- a/third_party/WebKit/Source/web/ChromeClientImpl.cpp

+++ b/third_party/WebKit/Source/web/ChromeClientImpl.cpp

@@ -58,7 +58,6 @@

#include "modules/bluetooth/BluetoothSupplement.h"

#include "modules/installedapp/InstalledAppController.h"

#include "modules/mediastream/UserMediaController.h"

-#include "modules/notifications/NotificationPermissionClient.h"

#include "modules/permissions/PermissionController.h"

#include "modules/presentation/PresentationController.h"

#include "modules/push_messaging/PushController.h"

@@ -109,7 +108,6 @@

#include "web/IndexedDBClientImpl.h"

#include "web/LocalFileSystemClient.h"

#include "web/NavigatorContentUtilsClientImpl.h"

-#include "web/NotificationPermissionClientImpl.h"

#include "web/PopupMenuImpl.h"

#include "web/WebFileChooserCompletionImpl.h"

#include "web/WebFrameWidgetImpl.h"

@@ -1124,7 +1122,6 @@ void ChromeClientImpl::installSupplements(LocalFrame& frame)

provideUserMediaTo(frame, UserMediaClientImpl::create(client->userMediaClient()));

}

- provideNotificationPermissionClientTo(frame, NotificationPermissionClientImpl::create());

provideIndexedDBClientTo(frame, IndexedDBClientImpl::create());

provideLocalFileSystemTo(frame, LocalFileSystemClient::create());

provideNavigatorContentUtilsTo(frame, NavigatorContentUtilsClientImpl::create(webFrame));