Fix page leaks in an embedder test

Fix page leaks in an embedder test

Embedder test's delegate function GetPage() calls FPDF_LoadPage() to
load a page which may be already loaded by embedder test itself.
Thus the page's ref count is increased unnecessarily.
This causes the page to be leaked. Fix this by putting the page map in
embedder test class and guarantee the page is loaded only once.

Also, fix leaks in this embedder tests by unloading the loaded pages to
properly release the resource.

BUG=pdfium:242
Committed: https://pdfium.googlesource.com/pdfium/+/0dadcc6fdab7ad1f2ee95d763f31aad5d3534f93

[Wei Li, 2016-08-19 23:41:14]

Patchset #1 (id:1) has been deleted

[Wei Li, 2016-08-19 23:41:47]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 23:41:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Wei Li, 2016-08-19 23:54:07]

weili@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[Wei Li, 2016-08-19 23:54:07]

pls review, thanks

[commit-bot: I haz the power, 2016-08-19 23:54:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 23:54:24]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-08-22 19:42:52]

https://codereview.chromium.org/2258333002/diff/20001/fpdfsdk/fsdk_mgr.cpp
File fpdfsdk/fsdk_mgr.cpp (right):

https://codereview.chromium.org/2258333002/diff/20001/fpdfsdk/fsdk_mgr.cpp#ne...
fpdfsdk/fsdk_mgr.cpp:303: pTempPage->Release();
might this cause the page to be removed from the map, invalidating it?  Do pages
clean themselves up when destroyed?

[Wei Li, 2016-08-23 18:01:16]

Patchset #2 (id:40001) has been deleted

[Wei Li, 2016-08-23 18:02:15]

Patchset #2 (id:60001) has been deleted

[Wei Li, 2016-08-23 18:14:51]

Description was changed from

==========
Fix CPDFXFA_Page leak and leaks in an embedder test

When getting a CPDFXFA_Page through *FFI_GetPage(), the page's ref
count is increased, its release() function needs to be called to update
its ref count so that this page can eventually be deleted. Add this
information into *FFI_GetPage()'s description and update its usage.

Also, fix leaks in an embedder tests by unloading the loaded pages to
release the resource.

BUG=pdfium:242
==========

to

==========
Fix page leaks in an embedder test

Embedder test's delegate function GetPage() calls FPDF_LoadPage()
to load a page which may be already loaded by embedder test itself.
Thus the page's ref count is increased unnecessarily.
This causes the page to be leaked. Fix this by putting the page map in embedder
test class and guarantee the page is loaded only once.

Also, fix leaks in this embedder tests by unloading the loaded pages to properly
release the resource.

BUG=pdfium:242
==========

[Wei Li, 2016-08-23 18:15:09]

Description was changed from

==========
Fix page leaks in an embedder test

Embedder test's delegate function GetPage() calls FPDF_LoadPage()
to load a page which may be already loaded by embedder test itself.
Thus the page's ref count is increased unnecessarily.
This causes the page to be leaked. Fix this by putting the page map in embedder
test class and guarantee the page is loaded only once.

Also, fix leaks in this embedder tests by unloading the loaded pages to properly
release the resource.

BUG=pdfium:242
==========

to

==========
Fix page leaks in an embedder test

Embedder test's delegate function GetPage() calls FPDF_LoadPage()
to load a page which may be already loaded by embedder test itself.
Thus the page's ref count is increased unnecessarily.
This causes the page to be leaked. Fix this by putting the page map in
embedder test class and guarantee the page is loaded only once.

Also, fix leaks in this embedder tests by unloading the loaded pages to properly
release the resource.

BUG=pdfium:242
==========

[Wei Li, 2016-08-23 18:15:26]

Description was changed from

==========
Fix page leaks in an embedder test

Embedder test's delegate function GetPage() calls FPDF_LoadPage()
to load a page which may be already loaded by embedder test itself.
Thus the page's ref count is increased unnecessarily.
This causes the page to be leaked. Fix this by putting the page map in
embedder test class and guarantee the page is loaded only once.

Also, fix leaks in this embedder tests by unloading the loaded pages to properly
release the resource.

BUG=pdfium:242
==========

to

==========
Fix page leaks in an embedder test

Embedder test's delegate function GetPage() calls FPDF_LoadPage()
to load a page which may be already loaded by embedder test itself.
Thus the page's ref count is increased unnecessarily.
This causes the page to be leaked. Fix this by putting the page map in
embedder test class and guarantee the page is loaded only once.

Also, fix leaks in this embedder tests by unloading the loaded pages to
properly release the resource.

BUG=pdfium:242
==========

[Wei Li, 2016-08-23 18:17:48]

Description was changed from

==========
Fix page leaks in an embedder test

Embedder test's delegate function GetPage() calls FPDF_LoadPage()
to load a page which may be already loaded by embedder test itself.
Thus the page's ref count is increased unnecessarily.
This causes the page to be leaked. Fix this by putting the page map in
embedder test class and guarantee the page is loaded only once.

Also, fix leaks in this embedder tests by unloading the loaded pages to
properly release the resource.

BUG=pdfium:242
==========

to

==========
Fix page leaks in an embedder test

Embedder test's delegate function GetPage() calls FPDF_LoadPage() to
load a page which may be already loaded by embedder test itself.
Thus the page's ref count is increased unnecessarily.
This causes the page to be leaked. Fix this by putting the page map in
embedder test class and guarantee the page is loaded only once.

Also, fix leaks in this embedder tests by unloading the loaded pages to
properly release the resource.

BUG=pdfium:242
==========

[Wei Li, 2016-08-23 18:18:44]

The CQ bit was checked by weili@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 18:18:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 18:30:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 18:30:03]

Dry run: This issue passed the CQ dry run.

[Wei Li, 2016-08-23 18:56:19]

take another approach, ptal, thanks

[Tom Sepez, 2016-08-24 01:04:41]

I think this works.  LGTM.

[Wei Li, 2016-08-24 04:10:33]

The CQ bit was checked by weili@chromium.org

[commit-bot: I haz the power, 2016-08-24 04:10:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 04:11:01]

Description was changed from

==========
Fix page leaks in an embedder test

Embedder test's delegate function GetPage() calls FPDF_LoadPage() to
load a page which may be already loaded by embedder test itself.
Thus the page's ref count is increased unnecessarily.
This causes the page to be leaked. Fix this by putting the page map in
embedder test class and guarantee the page is loaded only once.

Also, fix leaks in this embedder tests by unloading the loaded pages to
properly release the resource.

BUG=pdfium:242
==========

to

==========
Fix page leaks in an embedder test

Embedder test's delegate function GetPage() calls FPDF_LoadPage() to
load a page which may be already loaded by embedder test itself.
Thus the page's ref count is increased unnecessarily.
This causes the page to be leaked. Fix this by putting the page map in
embedder test class and guarantee the page is loaded only once.

Also, fix leaks in this embedder tests by unloading the loaded pages to
properly release the resource.

BUG=pdfium:242

Committed:
https://pdfium.googlesource.com/pdfium/+/0dadcc6fdab7ad1f2ee95d763f31aad5d353...
==========

[commit-bot: I haz the power, 2016-08-24 04:11:02]

Committed patchset #2 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/0dadcc6fdab7ad1f2ee95d763f31aad5d353...